967230 - No longer able to start the browser if CWD doesn't contain libicudata.52.dylib

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Description

[Boris Zbarsky [:bzbarsky]]

With a build from rev 2efbd5388bc7:

  mozilla% ../obj-firefox/dist/NightlyDebug.app/Contents/MacOS/firefox
  XPCOMGlueLoad error 4:0 for file /Users/bzbarsky/mozilla/vanilla/mozilla/../obj-firefox/dist/NightlyDebug.app/Contents/MacOS/libicuuc.52.dylib:
  Library not loaded: libicudata.52.dylib
  Referenced from: /Users/bzbarsky/mozilla/vanilla/obj-firefox/js/src/intl/icu/target/lib/libicuuc.52.1.dylib
  Reason: image not found
  Couldn't load XPCOM.

With a current tip build:

  /Users/bzbarsky/mozilla/inbound/obj-firefox/dist/NightlyDebug.app/Contents/MacOS
  XPCOMGlueLoad error 4:0 for file /Users/bzbarsky/mozilla/inbound/obj-firefox/dist/NightlyDebug.app/Contents/MacOS/libicuuc.52.dylib:
  Library not loaded: libicudata.52.dylib
  Referenced from: /Users/bzbarsky/mozilla/inbound/obj-firefox/dist/NightlyDebug.app/Contents/MacOS/libicuuc.52.dylib
  Reason: image not found
  Couldn't load XPCOM.

If I repeat that with cwd either ../obj-firefox/dist/NightlyDebug.app/Contents/MacOS/ or ../obj-firefox/dist/bin (still running the same binary from NightlyDebug.app), the build starts.

So it looks like we're using a cwd-relative path to look for libicudata.52.dylib?

This _may_ need --enable-shared-js.  Checking now.

Note that we're apparently only copying the .52.dylibs into dist/bin, not the .52.1.dylibs.  But the second error above doesn't mention .52.1 anywhere.

Comment 1

[Boris Zbarsky [:bzbarsky]]

A current tip opt build gives the second error above too.

Comment 2

[Boris Zbarsky [:bzbarsky]]

Er, I lied.  With the "current tip" build the error above is from running it slightly differently.  In particular, that one is if I do:

  mozilla% /Users/bzbarsky/mozilla/vanilla/obj-firefox/dist/NightlyDebug.app/Contents/MacOS/firefox

instead of using a relative path to the objdir.

Comment 3

[(no longer active)]

I have a fix which I cannot land because the tree is closed.

Comment 4

[(no longer active)]

Attachment: Fix

Comment 5

[(no longer active)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/d0f1ccbc7cfc