967259 - Intermittent Jetpack addon-page/main.test that add-on page has no chrome | chrome is not visible for addon page - false == true

Status: RESOLVED FIXED

Description

[Ryan VanderMeulen [:RyanVM]]

https://tbpl.mozilla.org/php/getParsedLog.php?id=34022681&tree=Mozilla-Aurora

Ubuntu VM 12.04 mozilla-aurora pgo test jetpack on 2014-02-03 13:35:27 PST for push afad6b72ed8d
slave: tst-linux32-spot-170

TEST-START | addon-page/main.test add-on page deprecation message
TEST-PASS | addon-page/main.test add-on page deprecation message | only one error is dispatched
TEST-PASS | addon-page/main.test add-on page deprecation message | the console message is an error
TEST-PASS | addon-page/main.test add-on page deprecation message | The message is deprecation message
TEST-END | addon-page/main.test add-on page deprecation message
TEST-START | addon-page/main.test that add-on page has no chrome
TEST-PASS | addon-page/main.test that add-on page has no chrome | chrome is visible for non addon page
TEST-UNEXPECTED-FAIL | addon-page/main.test that add-on page has no chrome | chrome is not visible for addon page - false == true
TEST-INFO | Traceback (most recent call last):
  File "resource://gre/modules/commonjs/sdk/timers.js", line 40, in notify
    callback.apply(null, args);
  File "resource://test-addon-page-at-jetpack/addon-page/lib/main.js", line 62, in exports["test that add-on page has no chrome"]/<
    'chrome is not visible for addon page');
  File "resource://gre/modules/commonjs/sdk/test/assert.js", line 124, in equal
    operator: "=="
  File "resource://gre/modules/commonjs/sdk/test/assert.js", line 88, in fail
    this._log.fail(message);
  File "resource://gre/modules/commonjs/sdk/deprecated/unit-test.js", line 83, in fail
    this.console.testMessage(false, false, this.test.name, message);
  File "resource://gre/modules/commonjs/sdk/test/harness.js", line 521, in testMessage
    this.trace();
TEST-PASS | addon-page/main.test that add-on page has no chrome | chrome is visible again
TEST-PASS | addon-page/main.test that add-on page has no chrome | add-on page tab is closed on unload
TEST-END | addon-page/main.test that add-on page has no chrome

Comment 1

[Erik Vold [:erikvold] (please needinfo? me)]

The Fennec tests fail for the same reason.

Comment 2

[Erik Vold [:erikvold] (please needinfo? me)]

(In reply to Erik Vold [:erikvold] [:ztatic] from comment #1)
> The Fennec tests fail for the same reason.

I should have said the test fails on Fennec for the same reason.

Comment 3

[Erik Vold [:erikvold] (please needinfo? me)]

This should be resolved now.

Comment 4

[Erik Vold [:erikvold] (please needinfo? me)]

The change I made in bug 967294 that should resolve this is to wait for the addon page tab to close before assuming it was closed.

Comment 5

[Ryan VanderMeulen [:RyanVM]]

Can we get this fix uplifted to 29 too?