967274 - [Contacts] Background doesn't scroll with the contacts causing expensive over-invalidation

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Contacts, defect, P1)

Description

[Benoit Girard (:BenWa)]

This is the same issue as bug 950250 but for the contacts app. See that bug for more details

Comment 1

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

Attachment: bug967274.patch

Benoit let me know if that's what you were looking for. If so I will ask another review to a contacts peer.

Comment 2

[Benoit Girard (:BenWa)]

Comment on attachment 8369785 [details] [diff] [review]
bug967274.patch

The overflow: scroll is on groups-container. The background color needs to be on a child of that element (excluding the element itself). Since there's 2 children we may need to introduce an intermediate element. Setting the background on both the form and selection may work but I'm not sure.

Comment 3

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

Attachment: bug967274.patch

Let's see if this one is better.

Comment 4

[Milan Sreckovic [:milan] (needinfo for best results)]

If this is r+, we need to uplift it, 1.3+. Bug 950250 covered the settings app.  We could also use this for SMS, call log, perhaps others.  Do you guys think we should open separate bugs for these, or just put all of the fixes into this one?

Comment 5

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

(In reply to Milan Sreckovic [:milan] from comment #4)
> If this is r+, we need to uplift it, 1.3+. Bug 950250 covered the settings
> app.  We could also use this for SMS, call log, perhaps others.  Do you guys
> think we should open separate bugs for these, or just put all of the fixes
> into this one?

We have separate bugs for all of them. I'm waiting for Francisco review as I want to make sure it does not break anything.

Comment 6

[Francisco Jordano [:arcturus] [:francisco]]

Comment on attachment 8369964 [details] [diff] [review]
bug967274.patch

Review of attachment 8369964 [details] [diff] [review]:
-----------------------------------------------------------------

Looking great to me, please rebase and merge.

Thanks Vivien!

Comment 7

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

master: https://github.com/mozilla-b2g/gaia/commit/5a00e3ee689a6534956985837677c5c2ac981500

Comment 8

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

v1.3: https://github.com/mozilla-b2g/gaia/commit/6d354f20f6202ee2fdec821d7f120797ba329775