967286 - Default to Layout.FRAME if layout type isn't specified in Home.panels.add

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: General, defect, P1)

Description

[:Margaret Leibovic]

See here for some example usage of the current Home.panels.add API:
https://wiki.mozilla.org/Mobile/Projects/Third-party_service_integration_MVP#JS_APIs

Right now we only support layout type FRAME, so we should just default to that to allow a developer to omit the layout property on their Home.panels.add options parameter.

We should add some logic in here to set panel.layout to this.Layout.Frame if it wasn't specified (but we should still throw an exception if some invalid layout was specified):
http://mxr.mozilla.org/mozilla-central/source/mobile/android/modules/Home.jsm#199

Comment 1

[Lucas Rocha (:lucasr)]

Attachment: Default to Layout.FRAME if layout type isn't specified (r=margaret)

Comment 2

[Lucas Rocha (:lucasr)]

Comment on attachment 8381291 [details] [diff] [review]
Default to Layout.FRAME if layout type isn't specified (r=margaret)

I realize this is a mentor bug but this is now a P1 bug. Let's get it out of the way.

Comment 3

[:Margaret Leibovic]

Comment on attachment 8381291 [details] [diff] [review]
Default to Layout.FRAME if layout type isn't specified (r=margaret)

Review of attachment 8381291 [details] [diff] [review]:
-----------------------------------------------------------------

Nice.

Comment 4

[Lucas Rocha (:lucasr)]

https://hg.mozilla.org/integration/fx-team/rev/95ff5102419c

Comment 5

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/95ff5102419c

Comment 6

[:Margaret Leibovic]

Setting P1 hub bugs to block hub v1 EPIC bug (targeting fx30 release).

Filter on epic-hub-bugs.