Closed Bug 967286 Opened 11 years ago Closed 11 years ago

Default to Layout.FRAME if layout type isn't specified in Home.panels.add

Categories

(Firefox for Android Graveyard :: General, defect, P1)

ARM
Android
defect

Tracking

(Not tracked)

RESOLVED FIXED
Firefox 30

People

(Reporter: Margaret, Assigned: lucasr)

References

Details

(Whiteboard: [mentor=margaret][lang=js])

Attachments

(1 file)

See here for some example usage of the current Home.panels.add API: https://wiki.mozilla.org/Mobile/Projects/Third-party_service_integration_MVP#JS_APIs Right now we only support layout type FRAME, so we should just default to that to allow a developer to omit the layout property on their Home.panels.add options parameter. We should add some logic in here to set panel.layout to this.Layout.Frame if it wasn't specified (but we should still throw an exception if some invalid layout was specified): http://mxr.mozilla.org/mozilla-central/source/mobile/android/modules/Home.jsm#199
Priority: -- → P1
Comment on attachment 8381291 [details] [diff] [review] Default to Layout.FRAME if layout type isn't specified (r=margaret) I realize this is a mentor bug but this is now a P1 bug. Let's get it out of the way.
Attachment #8381291 - Flags: review?(margaret.leibovic)
Assignee: nobody → lucasr.at.mozilla
Comment on attachment 8381291 [details] [diff] [review] Default to Layout.FRAME if layout type isn't specified (r=margaret) Review of attachment 8381291 [details] [diff] [review]: ----------------------------------------------------------------- Nice.
Attachment #8381291 - Flags: review?(margaret.leibovic) → review+
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 30
Setting P1 hub bugs to block hub v1 EPIC bug (targeting fx30 release). Filter on epic-hub-bugs.
Blocks: 1014025
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: