Closed Bug 967297 Opened 8 years ago Closed 8 years ago

Touching ipc/ipdl/ipdl/lower.py does not cause the IPDL files to be regenerated

Categories

(Firefox Build System :: General, defect)

x86
macOS
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED
mozilla30

People

(Reporter: ehsan.akhgari, Assigned: froydnj)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

This could be one reason for clobbering.
Gregory, can you please fix this or tell me how to fix this?  This will break the patch for bug 967167 when it gets checked in.
Flags: needinfo?(gps)
We may have this on file already. The make dependency file for IPDL isn't pulling in imported .py files in addition to self.
Blocks: clobber
Flags: needinfo?(gps)
This is not the absolute best solution, but it fits in well with what we
already have.
Attachment #8370179 - Flags: review?(gps)
This is a gross hack.  Why can't we just encode the dependency information in the build system instead?
(In reply to :Ehsan Akhgari (needinfo? me!) (slow responsiveness, emailacopolypse) from comment #4)
> This is a gross hack.  Why can't we just encode the dependency information
> in the build system instead?

Can you guarantee that dependency information won't get outdated?
Attachment #8370179 - Flags: review?(gps) → review+
(In reply to :Ehsan Akhgari (needinfo? me!) (slow responsiveness, emailacopolypse) from comment #4)
> This is a gross hack.  Why can't we just encode the dependency information
> in the build system instead?

This is a similar approach we use elsewhere.

Next step is to write out the Python dependencies into a .pp file somewhere so make won't invoke the IPDL processor if nothing has changed.
(In reply to comment #5)
> (In reply to :Ehsan Akhgari (needinfo? me!) (slow responsiveness,
> emailacopolypse) from comment #4)
> > This is a gross hack.  Why can't we just encode the dependency information
> > in the build system instead?
> 
> Can you guarantee that dependency information won't get outdated?

I take it that this is a rhetorical question.
Assignee: nobody → nfroyd
Keywords: checkin-needed
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/9185c4a586df
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla30
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.