Touching ipc/ipdl/ipdl/lower.py does not cause the IPDL files to be regenerated

RESOLVED FIXED in mozilla30

Status

RESOLVED FIXED
5 years ago
6 months ago

People

(Reporter: Ehsan, Assigned: froydnj)

Tracking

(Blocks: 1 bug)

Trunk
mozilla30
x86
Mac OS X
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Reporter)

Description

5 years ago
This could be one reason for clobbering.
(Reporter)

Comment 1

5 years ago
Gregory, can you please fix this or tell me how to fix this?  This will break the patch for bug 967167 when it gets checked in.
Blocks: 967167
Flags: needinfo?(gps)

Comment 2

5 years ago
We may have this on file already. The make dependency file for IPDL isn't pulling in imported .py files in addition to self.
Blocks: 941904
Flags: needinfo?(gps)
(Assignee)

Comment 3

5 years ago
Created attachment 8370179 [details] [diff] [review]
consider ipdl modules as inputs to the ipdl build process

This is not the absolute best solution, but it fits in well with what we
already have.
Attachment #8370179 - Flags: review?(gps)
(Reporter)

Comment 4

5 years ago
This is a gross hack.  Why can't we just encode the dependency information in the build system instead?
(In reply to :Ehsan Akhgari (needinfo? me!) (slow responsiveness, emailacopolypse) from comment #4)
> This is a gross hack.  Why can't we just encode the dependency information
> in the build system instead?

Can you guarantee that dependency information won't get outdated?
Attachment #8370179 - Flags: review?(gps) → review+

Comment 6

5 years ago
(In reply to :Ehsan Akhgari (needinfo? me!) (slow responsiveness, emailacopolypse) from comment #4)
> This is a gross hack.  Why can't we just encode the dependency information
> in the build system instead?

This is a similar approach we use elsewhere.

Next step is to write out the Python dependencies into a .pp file somewhere so make won't invoke the IPDL processor if nothing has changed.
(Reporter)

Comment 7

5 years ago
(In reply to comment #5)
> (In reply to :Ehsan Akhgari (needinfo? me!) (slow responsiveness,
> emailacopolypse) from comment #4)
> > This is a gross hack.  Why can't we just encode the dependency information
> > in the build system instead?
> 
> Can you guarantee that dependency information won't get outdated?

I take it that this is a rhetorical question.
(Reporter)

Updated

5 years ago
Assignee: nobody → nfroyd
Keywords: checkin-needed
(Reporter)

Updated

5 years ago
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/9185c4a586df
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla30

Updated

6 months ago
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.