967320 - Faulty IPC fuzzer should be able to fuzz only select protocols

Status: RESOLVED FIXED

(Core :: IPC, defect, P3)

Description

[Benoit Jacob [:bjacob] (mostly away)]

Attachment: fuzz-select-protocols

Because otherwise, especially in a debug build, I keep asserting all over the place before I get to hit the gfx bugs that are of interest to me.

The attached patch implements that in a hacky way to fuzz only gfx/layers actors, which are identified by "mozilla::layers::" being a substring of the actor type. It might be a starting point for doing this the right way, or it might be just a toy --- you decide. Meanwhile, it allows me to proceed with fuzzing gfx/layers protocols.

Comment 1

[Christoph Diehl [:posidron]]

Thanks Benoit!
We should probably read those white-list identifiers from a file. Though, I am not exactly sure where the best place for that would be - in the Faulty() constructor may be? Perhaps we can then provide the white-list from the outside with an additional environment variable.

Eg: export FAULTY_WHITELIST=mywhitelist.txt

I am a bit confused though. Should we not add the message names to a white-list or black-list?

Like:

PLayerTransaction::Msg_PLayerConstructor
PLayerTransaction::Msg_PCompositableConstructor

Comment 2

[Benoit Jacob [:bjacob] (mostly away)]

(In reply to Christoph Diehl [:cdiehl] from comment #1)
> Thanks Benoit!
> We should probably read those white-list identifiers from a file. Though, I
> am not exactly sure where the best place for that would be - in the Faulty()
> constructor may be? Perhaps we can then provide the white-list from the
> outside with an additional environment variable.
> 
> Eg: export FAULTY_WHITELIST=mywhitelist.txt

Sure, that seems like a good idea.

> 
> I am a bit confused though. Should we not add the message names to a
> white-list or black-list?
> 
> Like:
> 
> PLayerTransaction::Msg_PLayerConstructor
> PLayerTransaction::Msg_PCompositableConstructor

If someone has a need for per-message filtering, then sure you could do that.  In my case though, per-protocol filtering was fine enough granularity.

Comment 3

[Christoph Diehl [:posidron]]

Closing because a whitelist/blacklist has been added since.