967650 - final verification should report remote IP addresses

Status: RESOLVED FIXED

(Release Engineering :: General, defect)

Comment 1

[Rail Aliiev [:rail]]

Attachment: remote_ip.diff

Something like this?

Comment 2

[Rail Aliiev [:rail]]

Comment on attachment 8370175 [details] [diff] [review]
remote_ip.diff

%{remote_ip} is not supported by curl installed on the builders... :/

Comment 3

[Pete Moore [:pmoore][:pete]]

Attachment: Patch to add extra debug logging to curl commands in final verification, e.g. to see remote IP address

Hey Rail,

For the sake of tidiness this patch collects the actual headers, and the debug output, in separate files, and presents both of them in the log file.

I'll attach a sample log file to this bug now too...

Pete

Comment 4

[Pete Moore [:pmoore][:pete]]

Attachment: Example output generated when using the provided patch (https://bug967650.bugzilla.mozilla.org/attachment.cgi?id=8370240)

As mentioned about in comment 3 (https://bugzilla.mozilla.org/show_bug.cgi?id=967650#c3), here is the example output you get when applying the above patch (https://bug967650.bugzilla.mozilla.org/attachment.cgi?id=8370240)...

Thanks,
Pete

Comment 5

[Rail Aliiev [:rail]]

Comment on attachment 8370240 [details] [diff] [review]
Patch to add extra debug logging to curl commands in final verification, e.g. to see remote IP address

lgtm

Comment 6

[Pete Moore [:pmoore][:pete]]

https://hg.mozilla.org/build/tools/rev/1ea3fe646a48

Comment 7

[Pete Moore [:pmoore][:pete]]

Ah - probably should have added this comment here, instead of https://bugzilla.mozilla.org/show_bug.cgi?id=966637#c34 - duplicating here, as it is probably the correct bug to track this issue...

<copied and pasted from https://bugzilla.mozilla.org/show_bug.cgi?id=966637#c34>

Rail, do you want me to add -H "Pragma: akamai-x-cache-on, akamai-x-cache-remote-on, akamai-x-check-cacheable, akamai-x-get-cache-key, akamai-x-get-extracted-values, akamai-x-get-nonces, akamai-x-get-ssl-client-session-id, akamai-x-get-true-cache-key, akamai-x-serial-no, akamai-x-get-request-id" permanently to the curl requests in our final verification scripts, as per Eric Gonzalez Mora's suggestion, or is that redundant now?

Thanks,
Pete

</copy and paste>

Comment 8

[Rail Aliiev [:rail]]

Copy/paste from bug 966637 :)

If we can't use HEAD for final verification I'd try Nick's idea in bug 966637 comment 30 and use GET and Range for cases when HEAD fails.

Comment 9

[Pete Moore [:pmoore][:pete]]

I'm going to close this, as the code has been rolled out now to include the IP addresses. If we want to switch the HEAD implementation to a GET request with a limited range, that can be tracked in a separate bug later, if required.