Closed Bug 967708 Opened 7 years ago Closed 7 years ago
[B2G][l10n][Settings] German: "Change PIN" doesn't use localization
When the device's language is set to German and the user accesses Settings > SIM Security, the Change PIN option will not be translated. Repro Steps: 1) Update Buri to v1.3 BuildID: 20140203004001 2) Set the device's language to German. 3) Access Settings > SIM Security. 4) Observe Change PIN displayed at the bottom of the screen untranslated. Actual: Change PIN is displayed in English. Expected: (Describe the behavior you expected to have observed) Environmental Variables: Device: Buri 1.3 MOZ BuildID: 20140203004001 Gaia: f9a37c77efb4621a1f57e4695b497d18601fe134 Gecko: 3d9d920ca43b Version: 28.0a2 Firmware Version: V1.2-device.cfg Repro frequency: 100% See attached: screenshot
This issue does not reproduce in the latest v1.2 build. The string is shown translated as PIN ändern in the bottom of the screen. Environmental Variables: Device: Buri 1.2 MOZ BuildID: 20140203004002 Gaia: 539a25e1887b902b8b25038c547048e691bd97f6 Gecko: 9250d1b1cb6e Version: 26.0 Firmware Version: V1.2-device.cfg
This applies also to French, so likely to all messages. E.g. for German, it has been translated, see http://hg.mozilla.org/releases/gaia-l10n/v1_3/de/file/a6fa9dcfbab7/apps/settings/settings.properties#l731 Source files: https://github.com/mozilla-b2g/gaia/blob/v1.3/apps/settings/elements/simpin.html https://github.com/mozilla-b2g/gaia/blob/v1.3/apps/settings/locales/settings.en-US.properties#L710
Summary: [B2G][l10n][Settings] German: Change PIN is not translated for the German locale. → [B2G][l10n][Settings] German: "Change PIN" doesn't use localization
This issue has been found to occur in multiple languages. Languages issue was reproduced: - German - Russian - Italian - Bulgarian - Dutch - French - Hungarian - Spanish - Slovak Additional STR: If the string appears properly translated, resetting the phone will cause this issue to occur.
This also appears when language is set to Bengali
7 years ago
Assignee: nobody → ejchen
Comment on attachment 8370525 [details] [review] patch on github Arthur, can you help me review this small patch ? Thanks :)
Attachment #8370525 - Flags: review?(arthur.chen)
Comment on attachment 8370525 [details] [review] patch on github r=me. Thanks!
Attachment #8370525 - Flags: review?(arthur.chen) → review+
Merged on Gaia/master : d295729213142542ada460ede4fb7616ab473c56 Thanks :) Because this problem exists on v1.3, nominate this bug to 1.3? (if someone can help cherry-pick, please just go ahead directly, this is just a few-lines-change patch)
blocking-b2g: --- → 1.3?
Untranslated string = blocker.
blocking-b2g: 1.3? → 1.3+
This isn't late-l10n, the translateable string landed some time ago, it just didn't get used anymore: https://github.com/mozilla-b2g/gaia/blame/v1.3/apps/settings/locales/settings.en-US.properties#L710
To be clear, this is not late-l10n but an issue in engineering side. Also merged the patch on Gaia/v1.3 : fb35a67f1addf6d338eb344195b389e40b502721 Thanks all ! :)
This issue also occurs in Simplified Chinese. Environment: Gaia f9a37c77efb4621a1f57e4695b497d18601fe134 Gecko http://hg.mozilla.org/releases/mozilla-aurora/rev/3d9d920ca43b BuildID 20140203004001 Version 28.0a2
You need to log in before you can comment on or make changes to this bug.