967769 - Firefox should tell SpiderMonkey what sort of code each bit of JavaScript is

Status: REOPENED

(Core :: DOM: Core & HTML, defect)

Description

[Jim Blandy :jimb]

Firefox should tell SpiderMonkey whether the JavaScript it has asked it to evaluate is an event handler, a script element, and so on. One bug 332176 has landed, Firefox can do so by setting CompileOptions::introductionType to the appropriate string.

There's a draft spec for introductionType, below; naturally, SpiderMonkey itself takes care of "eval" and "Function".


introductionType *(not yet implemented)*

A string indicating how this source code was introduced into the system.
This accessor returns one of the following values:

-   `"eval"`, for code passed to `eval`.
-   `"Function"`, for code passed to the `Function` constructor.
-   `"Worker"`, for code loaded by calling the Web worker
    constructor—the worker's main script.
-   `"importScripts"`, for code by calling `importScripts` in a web
    worker.
-   `"handler"`, for code assigned to DOM elements' event handler IDL
    attributes.
-   `"scriptElement"`, for code belonging to `<script>` elements.
-   `undefined`, if the implementation doesn't know how the code was
    introduced.

Comment 1

[Jim Blandy :jimb]

Okay, bug 332176 has landed, so this is ready to implement. (It's one of the last remaining pieces needed for removing JSD...)

Comment 2

[Jim Blandy :jimb]

Actually, we should land bug 968580, too, before working on this.

Comment 3

[Jim Blandy :jimb]

Panos, since you've been working on bug 961325, which is in the same neighborhood as this, would you be interested in preparing a patch for this? This one should be really simple --- just passing a const char * in at each site that passes JS source to SpiderMonkey (whether it's run immediately or not) --- and I've been promising it to the Firebug people for months, as it's one of their final blockers.

The two prerequisites I mentioned above are quick patches, so hopefully they won't take long to review...

Comment 4

[Panos Astithas (he/him) [:past] (please ni?)]

OK, I'll give it a shot.

Comment 5

[Jim Blandy :jimb]

Attachment: Provide introductionType information at every place in Firefox that evaluates JavaScript code.

WIP; doesn't compile

Comment 6

[Jan Honza Odvarko [:Honza] (always need-info? me)]

(In reply to Jim Blandy :jimb from comment #5)
> Created attachment 8375222 [details] [diff] [review]
> Provide introductionType information at every place in Firefox that
> evaluates JavaScript code.
> 
> WIP; doesn't compile
Yeah, I am seeing:

4:40.26 c:\src\github.com\mozilla\gecko-dev\dom\src\jsurl\nsJSProtocolHandler.c
pp(296) : error C2660: 'nsIXPConnect::EvalInSandboxObject' : function does not t
ake 7 arguments

Is it easy to fix?
Honza

Comment 7

[Jim Blandy :jimb]

I'll trim this down and re-post.

Comment 8

[Anne (:annevk)]

I'm going to assume this got resolved somehow as the blocking bug is fixed.

Comment 9

[Boris Zbarsky [:bzbarsky]]

Sadly, that got resolved when the SpiderMonkey side was done; this is still a todo.

In particular, compare https://searchfox.org/mozilla-central/search?q=setIntroductionType&case=true to the list in comment 0: some of that list is covered, but not all.