96780 - NSPR changes to make debugging better on Mac OS X

Status: RESOLVED FIXED

(NSPR :: NSPR, defect)

Description

[Simon Fraser [no longer active]]

Debugging using Pro 7 on Mac OS X works better if you send in the file 
name, rather than the disk name, as the 4th param to GetDiskFragment 
calls. With this change, I'm able to debug component libraries on X 
without having to rename all the files. Patch coming.

I think we can make this change in Mac Classic too; this string shows up 
in the debugger, but is otherwise insignificant to CFM.

Comment 1

[Simon Fraser [no longer active]]

Attachment: macdll.c changes

Comment 2

[Conrad Carlen (not reading bugmail)]

Attachment: alternate patch

Comment 3

[Conrad Carlen (not reading bugmail)]

I did something similar. I changed the function where the fragment name is
fetched so there's one less call site to change and if something else is getting
the fragment name for some reason, it will get the same answer.

Actually, this should not be #ifdef'd for TARGET_CARBON but always done, even
for Classic. The benefit is that, when a sym file is not loaded and you see the
fragment name on the call stack, you know which file to open. Right now, we see
something like WEB_DLL and that means nsWebBrowser.shlb. Who would know?

Comment 4

[Simon Fraser [no longer active]]

Your change worries me more, conrad. It won't work via calls to 
pr_Mac_LoadNamedFragment(), and returning the file name, rather than the fragment 
name, will mess up NSPR's library cache in pr_Mac_LoadIndexedFragment(), 
especially if start to use multi-fragment CFM containers.

I did think of one side-effect of making this change; it would probably affect 
Talkback. I think we'd have to change the names of the .xSYM files that we supply 
for talkback, for XPCOM component libraries.

Comment 5

[Steve Dagley]

Just pointing out if the change is #ifdef TARGET_CARBON we don't need to worry 
about Talkback 

Comment 6

[Simon Fraser [no longer active]]

This went in with the Pro 7 landing.