Closed
Bug 967907
Opened 10 years ago
Closed 10 years ago
Change the in-product link to support
Categories
(Firefox for Metro Graveyard :: General, defect, P1)
Tracking
(firefox28 verified, firefox29 verified, firefox30 verified, b2g-v1.3 fixed)
VERIFIED
FIXED
Firefox 30
People
(Reporter: verdi, Assigned: mbrubeck)
References
Details
(Whiteboard: [release28] p=1 s=it-30c-29a-28b.1 r=ff28)
Attachments
(1 file)
2.44 KB,
patch
|
jimm
:
review+
rrosario
:
feedback+
Sylvestre
:
approval-mozilla-aurora+
Sylvestre
:
approval-mozilla-beta+
|
Details | Diff | Splinter Review |
We currently use https://support.mozilla.org/1/firefox/%VERSION%/%OS%/%LOCALE%/firefox-help to link to the support site from Settings > Help. This is the same url that we use for Desktop Firefox. SUMO needs a different link so that we can send touch users to a different landing page. I propose that we use https://support.mozilla.org/1/touch/%VERSION%/%OS%/%LOCALE%/firefox-help I wasn't able to verify with Ricky that this will work so I'll add a needs info for him.
Reporter | ||
Updated•10 years ago
|
Flags: needinfo?(rrosario)
Comment 1•10 years ago
|
||
(In reply to Verdi [:verdi] from comment #0) > I propose that we use > https://support.mozilla.org/1/touch/%VERSION%/%OS%/%LOCALE%/firefox-help > > I wasn't able to verify with Ricky that this will work so I'll add a needs > info for him. This WFM!
Flags: needinfo?(rrosario)
Updated•10 years ago
|
Blocks: metrov1backlog
Whiteboard: [feature] p=0
Assignee | ||
Updated•10 years ago
|
Assignee: nobody → mbrubeck
status-firefox28:
--- → affected
status-firefox29:
--- → affected
status-firefox30:
--- → affected
Whiteboard: [feature] p=0 → [release28] [feature] p=1 s=it-30c-29a-28b.1
Assignee | ||
Comment 2•10 years ago
|
||
Changes app.support.baseURL to: https://support.mozilla.org/1/touch/%VERSION%/%OS%/%LOCALE%/ and changes the "Help (online)" link in the Settings charm to: https://support.mozilla.org/1/touch/%VERSION%/%OS%/%LOCALE%/firefox-help
Attachment #8370489 -
Flags: review?(jmathies)
Attachment #8370489 -
Flags: feedback?(rrosario)
Updated•10 years ago
|
Status: NEW → ASSIGNED
Priority: -- → P1
QA Contact: jbecerra
Target Milestone: --- → Firefox 28
Comment 3•10 years ago
|
||
Comment on attachment 8370489 [details] [diff] [review] patch Review of attachment 8370489 [details] [diff] [review]: ----------------------------------------------------------------- LGTM
Attachment #8370489 -
Flags: feedback?(rrosario) → feedback+
Updated•10 years ago
|
Attachment #8370489 -
Flags: review?(jmathies) → review+
Assignee | ||
Comment 4•10 years ago
|
||
https://hg.mozilla.org/integration/fx-team/rev/c31551a39157
Comment 5•10 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/c31551a39157
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Updated•10 years ago
|
Whiteboard: [release28] [feature] p=1 s=it-30c-29a-28b.1 → [release28] p=1 s=it-30c-29a-28b.1 r=ff28
Assignee | ||
Updated•10 years ago
|
Assignee | ||
Comment 6•10 years ago
|
||
Comment on attachment 8370489 [details] [diff] [review] patch [Approval Request Comment] Bug caused by (feature/regressing bug #): Metro User impact if declined: Metro Firefox users directed to desktop Firefox support pages. Testing completed (on m-c, etc.): On m-c since 2/7. Risk to taking this patch (and alternatives if risky): Very low-risk Metro-only patch to change some in-product SUMO links. String or IDL/UUID changes made by this patch: None.
Attachment #8370489 -
Flags: approval-mozilla-beta?
Attachment #8370489 -
Flags: approval-mozilla-aurora?
Comment 7•10 years ago
|
||
Went through the following issue for iteration IT-30C-29A-28B.1 (firefox30 verification), used the following build: - http://ftp.mozilla.org/pub/mozilla.org/firefox/nightly/2014-02-18-03-02-02-mozilla-central/ - Ensured taping/selecting "Help (online)" launches the correct link in fxmetro --> https://support.mozilla.org/en-US/products/firefox-windows-8-touch?as=u&utm_source=inproduc - Ensured taping/selecting "Help" launches the correct link in fxdesktop --> https://support.mozilla.org/en-US/products/firefox?as=u&utm_source=inproduct - Ensured that the fxmetro help webpage clearly display's "Firefox for Windows 8 Touch" - Ensured that the fxdesktop help webpage clearly display's "Firefox" - Ensured that the fxmetro knowledge base display's relevant Windows 8/Metro content (although currently very limited) - Ensured that taping "Help (online)" correctly opens a new tab in the correct order under the Navigation App Bar - Ensured that taping "Help (online)" correctly slides in the Navigation App Bar, opens the correct Tab and dismisses the Navigation App Bar - Ensured that after several switches between the two environments (fxmetro & fxdesktop), the correct links are still being opened - Went through the above test cases in different variations of snapped view without any issues Used the following devices to test the following issue: - MS Surface Pro 2 (Passed) - Lenovo X1 Carbon (Passed) Will be using the above test cases for Aurora/BETA verification once the uplift has been approved/landed
Updated•10 years ago
|
Attachment #8370489 -
Flags: approval-mozilla-beta?
Attachment #8370489 -
Flags: approval-mozilla-beta+
Attachment #8370489 -
Flags: approval-mozilla-aurora?
Attachment #8370489 -
Flags: approval-mozilla-aurora+
Updated•10 years ago
|
Target Milestone: Firefox 28 → Firefox 30
Comment 8•10 years ago
|
||
https://hg.mozilla.org/releases/mozilla-aurora/rev/f3901355f6fb https://hg.mozilla.org/releases/mozilla-beta/rev/d244572b8eb5
Updated•10 years ago
|
status-b2g-v1.3:
--- → fixed
Comment 10•10 years ago
|
||
Went through the following issue for iteration IT-30C-29A-28B.1 (firefox30 verification), used the following build: - http://ftp.mozilla.org/pub/mozilla.org/firefox/nightly/2014-02-21-00-40-01-mozilla-aurora/ - Went through the test cases that have been added in comment #7 without any issues - Ensured that the links from all the flyouts are directing users to the correct locations - Ensured that all the flyouts under the "Settings" charm are working without any issues Used the following devices to test the following issue: - MS Surface Pro 2 (Passed) - Lenovo X1 Carbon (Passed) This didn't make it into 28.0b4, will finish verification once a new BETA is released.
Comment 11•10 years ago
|
||
Flagging for verification in tomorrow's Beta.
Status: RESOLVED → VERIFIED
Keywords: verifyme
Comment 12•10 years ago
|
||
Verified as fixed with Firefox 28 beta 6 on Win 8 64-bit.
You need to log in
before you can comment on or make changes to this bug.
Description
•