967921 - User message 'Changing to Free will put your app back into review.' is not true

Status: VERIFIED FIXED

(Marketplace Graveyard :: Developer Pages, defect, P4)

Description

[krupa raj[:krupa]]

Attachment: screenshot

steps to reproduce:
1. Load https://marketplace-dev.allizom.org/developers/app/in-app-payment-tester-1/payments/
2. Click on the tab 'Free'
3. Notice the user message next to 'Change to Free' button



observed behavior:
User message says 'Changing to Free will put your app back into review.' which is untrue.

Comment 1

[Mathieu Pillard [:mat]]

Stuart: what should happen here? is the message wrong or the behaviour wrong ?

Comment 2

[Stuart Colville [:muffinresearch]]

This behaviour has been there for a while and I recall speaking to someone about it when I came across it. (I'm not sure who that was unfortunately), iirc the conclusion was that the behaviour is the expected behaviour and the copy didn't need to change because it makes people think about changing so they don't flip back and forth. But that said this feels like it might be something that would be worth re-visiting as a message that doesn't reflect reality *is* confusing.

Comment 3

[Andy McKay]

If the text isn't valid, let's not show it.

Comment 4

[Ram Dayal Vaishnav [:ram]]

Hi Wil,

I could like to work on this. Can you please assign this to me ?

Thanks,
Ram

Comment 5

[Ram Dayal Vaishnav [:ram]]

Attachment: https://github.com/mozilla/zamboni/pull/2938

Kindly review the patch.

Comment 6

[Rob Hudson [:robhudson]]

Merged: https://github.com/mozilla/zamboni/commit/afc82b3d

Thanks for the patch!

Comment 7

[Madalin Cotetiu]

Verified as fixed in FF39(Win7) in marketplace-dev.allizom.org
Postfix screencast: http://screencast.com/t/qhrkeiS2eZ

Comment 8

[havi hoffman [:havi]]

(In reply to Ram Dayal Vaishnav [:Ram] from comment #5)
> Created attachment 8568778 [details] [review]
> https://github.com/mozilla/zamboni/pull/2938
> 
> Kindly review the patch.

Sorry, I am NOT the right person to review a patch - I don't have the skills. Afraid I don't know how I ended up on the bug. Could someone remove me please? TIA

Comment 9

[Ram Dayal Vaishnav [:ram]]

Hi Havi, 

Your name was being shown under suggested reviewers by bugzilla, so asked you to review. I am removing you from the bug (by the way, this is reviewed & merged :D ).

Thanks,
Ram

Comment 10

[Ram Dayal Vaishnav [:ram]]

I'm unable to remove you Havi. You can do it yourself by checking 'never email me about this bug' in front of "Ignore Bug Mail" option at the top of the page.

* Bdw, Since this bug is already Fixed, you should not receive any mail from this now.