968091 - [Cost Control] Use lazy-load to load JS dependencies.

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Cost Control, defect, P2)

Description

[Salvador de la Puente González [:salva]]

Cost Control should be using a lazy load approach to improve performance and responsiveness.

Comment 1

[Marina Rodríguez [:mai]]

Attachment: patch 1.0

Please, could you review the patch?
Regards

Comment 2

[Salvador de la Puente González [:salva]]

Comment on attachment 8378850 [details] [review]
patch 1.0

As far as I can see, this looks great and not noticeable regressions appear. Furthermore tests are passing! I think this is a good starting point but we should open follow ups in order to develop a dependency map to load things just when strictly needed. ,)

Comment 3

[Marina Rodríguez [:mai]]

Nominated to 1.4, I attach two videos to check the improvement of the performance:

master (1.4) --> http://youtu.be/3MiLUuPy7Ec
master (1.4) + patch 968091 --> http://youtu.be/DHsISI-ZKlg

Regards

Comment 4

[Noemí Freire (:noemi)]

Triage: not blocking and seems risky, please land it in master when v1.4 has been created. Thanks!

Comment 5

[Marina Rodríguez [:mai]]

Master: fa71465516db09a8ea0f2db58336fd7772107e7a