968141 - Remove nsPrinterFeatures, print.tmp.printerfeatures from GTK Printing

Status: RESOLVED FIXED

(Core :: Printing: Setup, defect)

Description

[Oskar Eisemuth]

Attachment: nsDeviceContextSpecGTK: Remove nsPrinterFeatures (spaming print.tmp.printerfeatures into the prefs) not used by current code.

The temporary prefs print.tmp.printerfeatures and nsPrinterFeatures should go.

The current GTK code won't use any of the print.tmp.printerfeatures, 
technical the PS Paper list is limited and incompatible to GTK code anyway.

The PageSetup and Print Dialog use native GTK Dialogs anyway.

Bug 136058 may be closed as well, it doesn't apply any more to current code.

As Bug 629500 is a massively step, this is start of a small step by step version to tidy the print system from old stuff, easier to follow.

Comment 1

[Robert O'Callahan (:roc) (email my personal email if necessary)]

(In reply to Oskar Eisemuth from comment #0)
> The temporary prefs print.tmp.printerfeatures and nsPrinterFeatures should
> go.
> 
> The current GTK code won't use any of the print.tmp.printerfeatures, 
> technical the PS Paper list is limited and incompatible to GTK code anyway.

Thanks!

> Bug 136058 may be closed as well, it doesn't apply any more to current code.

Done. I have given you editbugs permission so you can do that sort of thing yourself.

Comment 2

[Oskar Eisemuth]

Attachment: Remove print.whileInPrintPreview and print.tmp.printerfeatures can_use_multiple_devicecontexts_concurrently.

The patch removes a remaining piece in PrintPreview of temporary pref, the print.whileInPrintPreview seems to be introduced only for PostScript GFX backend as workaround. However Print in PrintPreview was enabled by default with Bug 126802 a long time ago. So this patch removes print.whileInPrintPreview completly.

Comment 3

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/9ea3501ac619
https://hg.mozilla.org/integration/mozilla-inbound/rev/4153850acd1e

Comment 4

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/9ea3501ac619
https://hg.mozilla.org/mozilla-central/rev/4153850acd1e