Closed Bug 968179 Opened 6 years ago Closed 6 years ago

Fennec crashes when using PanelGridView

Categories

(Firefox for Android :: Awesomescreen, defect)

All
Android
defect
Not set

Tracking

()

RESOLVED FIXED
Firefox 30

People

(Reporter: lucasr, Assigned: lucasr)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

Bug 965070 and bug 963721 kinda depended on each other but landed independently. PanelGridView is required to implement the PanelView interface now.
Attachment #8370729 - Flags: review?(margaret.leibovic)
Comment on attachment 8370729 [details] [diff] [review]
Fix crasher when using grid views in dynamic panels (r=margaret)

Review of attachment 8370729 [details] [diff] [review]:
-----------------------------------------------------------------

::: mobile/android/base/home/PanelGridView.java
@@ +84,5 @@
> +            final String url = cursor.getString(urlIndex);
> +
> +            mUrlOpenListener.onUrlOpen(url, EnumSet.of(OnUrlOpenListener.Flags.OPEN_WITH_INTENT));
> +        }
> +    }

I don't really like that this is copy/pasted over from PanelListView, but we can refactor later if this starts to grow or if we need to copy it into a third place.
Attachment #8370729 - Flags: review?(margaret.leibovic) → review+
(In reply to :Margaret Leibovic from comment #2)
> Comment on attachment 8370729 [details] [diff] [review]
> Fix crasher when using grid views in dynamic panels (r=margaret)
> 
> Review of attachment 8370729 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> ::: mobile/android/base/home/PanelGridView.java
> @@ +84,5 @@
> > +            final String url = cursor.getString(urlIndex);
> > +
> > +            mUrlOpenListener.onUrlOpen(url, EnumSet.of(OnUrlOpenListener.Flags.OPEN_WITH_INTENT));
> > +        }
> > +    }
> 
> I don't really like that this is copy/pasted over from PanelListView, but we
> can refactor later if this starts to grow or if we need to copy it into a
> third place.

Yeah, let's see how this code evolves before doing any refactorings. It's not a lot of code.
https://hg.mozilla.org/mozilla-central/rev/4aee7615f1a4
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 30
You need to log in before you can comment on or make changes to this bug.