968179 - Fennec crashes when using PanelGridView

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: Awesomescreen, defect)

Description

[Lucas Rocha (:lucasr)]

Bug 965070 and bug 963721 kinda depended on each other but landed independently. PanelGridView is required to implement the PanelView interface now.

Comment 1

[Lucas Rocha (:lucasr)]

Attachment: Fix crasher when using grid views in dynamic panels (r=margaret)

Comment 2

[:Margaret Leibovic]

Comment on attachment 8370729 [details] [diff] [review]
Fix crasher when using grid views in dynamic panels (r=margaret)

Review of attachment 8370729 [details] [diff] [review]:
-----------------------------------------------------------------

::: mobile/android/base/home/PanelGridView.java
@@ +84,5 @@
> +            final String url = cursor.getString(urlIndex);
> +
> +            mUrlOpenListener.onUrlOpen(url, EnumSet.of(OnUrlOpenListener.Flags.OPEN_WITH_INTENT));
> +        }
> +    }

I don't really like that this is copy/pasted over from PanelListView, but we can refactor later if this starts to grow or if we need to copy it into a third place.

Comment 3

[Lucas Rocha (:lucasr)]

(In reply to :Margaret Leibovic from comment #2)
> Comment on attachment 8370729 [details] [diff] [review]
> Fix crasher when using grid views in dynamic panels (r=margaret)
> 
> Review of attachment 8370729 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> ::: mobile/android/base/home/PanelGridView.java
> @@ +84,5 @@
> > +            final String url = cursor.getString(urlIndex);
> > +
> > +            mUrlOpenListener.onUrlOpen(url, EnumSet.of(OnUrlOpenListener.Flags.OPEN_WITH_INTENT));
> > +        }
> > +    }
> 
> I don't really like that this is copy/pasted over from PanelListView, but we
> can refactor later if this starts to grow or if we need to copy it into a
> third place.

Yeah, let's see how this code evolves before doing any refactorings. It's not a lot of code.

Comment 4

[Lucas Rocha (:lucasr)]

https://hg.mozilla.org/integration/fx-team/rev/4aee7615f1a4

Comment 5

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/4aee7615f1a4