968232 - android nightlies failing to submit to balrog because of forbidden domain

Status: RESOLVED FIXED

(Release Engineering :: General, defect)

Description

[[e-mail] (:bhearsum)]

They're trying to submit fileUrls such as https://ftp-ssl.mozilla.org/pub/mozilla.org/mobile/nightly/2014/02/2014-02-05-03-02-03-mozilla-central-android/fennec-30.0a1.multi.android-arm.apk, and ftp-ssl.mozilla.org isn't in the domain whitelist. This is clearly because completeMarUrl has changed from ftp -> ftp-ssl, but I'm not sure if that was intentional or not.

So, we either need to add ftp-ssl to Balrog's whitelist or somehow get the client submitting ftp.mozilla.org URLs again.

Comment 1

[[e-mail] (:bhearsum)]

This might be a dupe of bug 967452...

Comment 2

[[e-mail] (:bhearsum)]

Oh, no. This is actually fallout from that fix.

Comment 3

[[e-mail] (:bhearsum)]

OK, so the URL that ends up being used for the completeMarUrl originates as mobile_download_base_url in production_config.py: https://github.com/mozilla/build-buildbot-configs/blob/master/mozilla/production_config.py#L64

And ends up as downloadBaseURL in MercurialBuildFactory.

I don't see downloadBaseURL in factory.py used for anything except update creation, which makes me think that we should revert mobile_download_base_url to http://ftp.mozilla.org.

Comment 4

[[e-mail] (:bhearsum)]

Attachment: revert mobile download base url

See previous comment for analysis.

Comment 5

[Aki Sasaki (not active)]

Comment on attachment 8370801 [details] [diff] [review]
revert mobile download base url

We want to keep https://ftp-ssl.
Can we add it to the balrog whitelist instead?

Comment 6

[Aki Sasaki (not active)]

Comment on attachment 8370801 [details] [diff] [review]
revert mobile download base url

[09:40]	<bhearsum>	but i don't see any use of mobile_download_base_url except to stuff it into a snippet/balrog blob
[09:42]	<aki>	looks like you're right
[09:42]	<aki>	i'd guess we'd want to serve updates over ssl anyway, because security, but not a blocker for aws

Comment 7

[[e-mail] (:bhearsum)]

This patch is in production, and I've triggered a new set of Android nightlies on mozilla-central.

Comment 8

[[e-mail] (:bhearsum)]

The retriggered nightlies submitted data to Balrog fine -- users are getting updates to them now.