Closed Bug 968351 Opened 6 years ago Closed 6 years ago

Allow test manifests with just support-files

Categories

(Firefox Build System :: General, defect)

defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED
mozilla30

People

(Reporter: ted, Assigned: ted)

References

Details

Attachments

(1 file, 1 obsolete file)

Currently we don't allow test manifests with just support-files under the DEFAULT section. I had to fix manifestparser to expose this data first (that's bug 968321), but it was fairly straightforward after that.

We have a number of Makefiles in the tree right now that install solely support files for Mochitests, so we need this to finish the conversion.
Blocks: 920185
Depends on: 968321
Comment on attachment 8370922 [details] [diff] [review]
Allow test manifests with just support-files

Review of attachment 8370922 [details] [diff] [review]:
-----------------------------------------------------------------

LGTM!
Attachment #8370922 - Flags: review?(gps) → review+
Thanks!
Flags: in-testsuite?
Flags: in-testsuite?
Blocks: 968837
Oops, a few stupid things on Try:
https://tbpl.mozilla.org/?tree=Try&rev=2c6285001bfb

Two fixes needed:
1) Need to os.path.normpath the manifest name in emitter.py because that's what manifestdestiny does, that's the bustage on Windows.
2) The unit test was relying on the ordering of dict keys (oops), added some sorting.

New try push:
https://tbpl.mozilla.org/?tree=Try&rev=4ded4d2dc418
Updated patch, for reference.
Attachment #8370922 - Attachment is obsolete: true
https://hg.mozilla.org/mozilla-central/rev/e4ad64c00537
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla30
Flags: in-testsuite+
Blocks: 969585
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.