968351 - Allow test manifests with just support-files

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Description

[(not currently active) Ted Mielczarek]

Currently we don't allow test manifests with just support-files under the DEFAULT section. I had to fix manifestparser to expose this data first (that's bug 968321), but it was fairly straightforward after that.

We have a number of Makefiles in the tree right now that install solely support files for Mochitests, so we need this to finish the conversion.

Comment 1

[(not currently active) Ted Mielczarek]

Attachment: Allow test manifests with just support-files

Comment 2

[Gregory Szorc [:gps]]

Comment on attachment 8370922 [details] [diff] [review]
Allow test manifests with just support-files

Review of attachment 8370922 [details] [diff] [review]:
-----------------------------------------------------------------

LGTM!

Comment 3

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

Thanks!

Comment 4

[(not currently active) Ted Mielczarek]

Oops, a few stupid things on Try:
https://tbpl.mozilla.org/?tree=Try&rev=2c6285001bfb

Two fixes needed:
1) Need to os.path.normpath the manifest name in emitter.py because that's what manifestdestiny does, that's the bustage on Windows.
2) The unit test was relying on the ordering of dict keys (oops), added some sorting.

New try push:
https://tbpl.mozilla.org/?tree=Try&rev=4ded4d2dc418

Comment 5

[(not currently active) Ted Mielczarek]

Attachment: Allow test manifests with just support-files.

Updated patch, for reference.

Comment 6

[(not currently active) Ted Mielczarek]

https://hg.mozilla.org/integration/mozilla-inbound/rev/e4ad64c00537

Comment 7

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/e4ad64c00537