968453 - Add unit tests for x.509 extension parsing in mozilla::pkix's BackCert::Init

Status: NEW

(Core :: Security: PSM, defect, P3)

Description

[Brian Smith (:briansmith, :bsmith, use NEEDINFO?)]

Follow-up to David's review in bug 921891.

Comment 1

[Dana Keeler (she/her) (use needinfo) [:keeler]]

(In reply to David Keeler [:keeler] (use needinfo?) from bug 921891 comment #10)
> Review of attachment 8370948 [details] [diff] [review]:
> ::: security/insanity/lib/pkixbuild.cpp
> @@ +76,5 @@
> > +      if (*out) {
> > +        // Duplicate extension
> > +        return Fail(RecoverableError, SEC_ERROR_EXTENSION_VALUE_INVALID);
> > +      }
> > +      *out = &ext->value;
> 
> This whole function is subtle. I think I understand it, but we should be
> careful here and make sure we have good test coverage.

I guess I meant things like duplicate extensions? Anyway, looks like the implementation is now at https://dxr.mozilla.org/mozilla-central/rev/4d63dde701b47b8661ab7990f197b6b60e543839/security/pkix/lib/pkixcert.cpp#173