Closed
Bug 968478
Opened 11 years ago
Closed 11 years ago
Put Scrollable Opaque Background Behind Calendar App
Categories
(Firefox OS Graveyard :: Gaia::Calendar, defect, P1)
Tracking
(b2g-v1.3 affected, b2g-v1.3T affected)
VERIFIED
FIXED
1.4 S2 (28feb)
People
(Reporter: mchang, Assigned: mchang)
References
Details
(Keywords: perf, Whiteboard: [c=handeye p=1 s= u=])
Attachments
(2 files, 4 obsolete files)
No description provided.
|
Assignee | |
Comment 1•11 years ago
|
||
|
|
Assignee | |
Comment 2•11 years ago
|
||
Comment on attachment 8371087 [details] [review]
https://github.com/mozilla-b2g/gaia/pull/16008
Hey James! Just a fixup to improve the scrolling performance of some areas of calendar. You can read the meta bug or ping me if you have any questions. Thanks!
Attachment #8371087 -
Flags: review?(jlal)
|
|
Assignee | |
Updated•11 years ago
|
Attachment #8371087 -
Flags: review?(jlal) → review?(21)
|
||
Comment 3•11 years ago
|
||
Comment on attachment 8371087 [details] [review]
https://github.com/mozilla-b2g/gaia/pull/16008
r+ with nits.
Attachment #8371087 -
Flags: review?(21) → review+
|
|
Assignee | |
Comment 4•11 years ago
|
||
Carrying r+ over
Attachment #8371087 -
Attachment is obsolete: true
Attachment #8373231 -
Flags: review+
|
|
Assignee | |
Comment 5•11 years ago
|
||
master - 4db70547e146f776461a9094de8829b5327b80b6
v1.3 - 88bda206b1def5d4beac3be851c904414563bea3
v1.3t - 76e32d1f2f0e747dd7f5e5097a00129a14aa9d02
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
status-b2g-v1.3:
--- → fixed
status-b2g-v1.3T:
--- → fixed
Resolution: --- → FIXED
|
|
||
Comment 6•11 years ago
|
||
It looks like this regressed Calendar and created a probable 1.3 blocker -- see bug 971195.
Mason, should we back this out?
Flags: needinfo?(mchang)
|
|
||
Comment 8•11 years ago
|
||
(In reply to Mason Chang [:mchang] from comment #7)
> Hi Dylan, yes please back this out.
John - Can you back this out?
Flags: needinfo?(jhford)
|
||
Comment 9•11 years ago
|
||
Reverted:
master: 9786c35567a238a30560b387061765dab998232e
v1.3: 33bd87c31d6dd0ffd1b36f5061541b5abda943f4
v1.3t: e755d6bc72b9f4cc18fca8e0a677ffa4e591e46b
Status: RESOLVED → REOPENED
Flags: needinfo?(jhford)
Resolution: FIXED → ---
|
|
||
Comment 10•11 years ago
|
||
it seems that the real cause of the Bug 971195 was not this patch; the patch only made it easier to spot the error. See: https://bugzilla.mozilla.org/show_bug.cgi?id=971904#c1
See Also: → 971904
|
|
Assignee | |
Comment 11•11 years ago
|
||
Let's try this again. Just tested with a greater than 2 hour event in the day view and it looks ok.
Attachment #8373231 -
Attachment is obsolete: true
Attachment #8383399 -
Flags: review-
|
|
Assignee | |
Updated•11 years ago
|
Attachment #8383399 -
Flags: review- → review?(mmedeiros)
|
|
||
Comment 12•11 years ago
|
||
Comment on attachment 8383399 [details] [review]
https://github.com/mozilla-b2g/gaia/pull/16723
I added some comments to the PR. It is not having the expected behavior on the week view since the `.scroll > .children` doesn't scale to fit the content. I would also group it with existing rules to reduce chance of conflicts in the future.
Attachment #8383399 -
Flags: review?(mmedeiros) → review-
Flags: needinfo?(mchang)
|
|
Assignee | |
Comment 13•11 years ago
|
||
Fixed up with your comments. Thanks!
Attachment #8383399 -
Attachment is obsolete: true
Attachment #8383851 -
Flags: review?(mmedeiros)
Flags: needinfo?(mchang)
|
|
Assignee | |
Comment 14•11 years ago
|
||
|
|
||
Comment 15•11 years ago
|
||
Comment on attachment 8383851 [details] [review]
https://github.com/mozilla-b2g/gaia/pull/16747
r+. still need to wait the Bug 972666 to be merged tho
Attachment #8383851 -
Flags: review?(mmedeiros) → review+
|
|
Assignee | |
Comment 16•11 years ago
|
||
Carrying r+ over. Modified to resolve conflicts.
Attachment #8383851 -
Attachment is obsolete: true
Attachment #8383916 -
Flags: review+
|
|
Assignee | |
Comment 17•11 years ago
|
||
Landed in master: 26fa8fe02e656655bc9b89e0c5e74f135965e799
Status: REOPENED → RESOLVED
Closed: 11 years ago → 11 years ago
Resolution: --- → FIXED
|
|
||
Updated•11 years ago
|
Target Milestone: 1.4 S1 (14feb) → 1.4 S2 (28feb)
|
|
||
Comment 18•11 years ago
|
||
[Environment]
Gaia 6c109df47006b08c082761c0ddd6ba53a864983a
Gecko https://hg.mozilla.org/mozilla-central/rev/21f293fc8d34
BuildID 20140309160201
Version 30.0a1
ro.build.version.incremental=eng.archermind.20131114.105818
ro.build.date=Thu Nov 14 10:58:33 CST 2013
[Result]
PASS
Bug fixed, I marked to "VERIFIED"
Status: RESOLVED → VERIFIED
You need to log in
before you can comment on or make changes to this bug.
Description
•