968491 - Mark security/certverifier as FAIL_ON_WARNINGS

Status: RESOLVED FIXED

(Core :: Security: PSM, defect)

Description

[Daniel Holbert [:dholbert]]

security/certverifier is nearly warning-free, aside from one warning (bug 962693 comment 10) that I think Camilo is posting a patch to suppress with #ifdefs soon.

One that patch is in, we can mark this directory as FAIL_ON_WARNINGS.  Proof:
  https://tbpl.mozilla.org/?tree=Try&rev=4b402b646287

(That Try run includes a s/static/inline/ hack to disable the aforementioned warning from bug 962693)

Comment 1

[Daniel Holbert [:dholbert]]

Attachment: fix

Comment 2

[Daniel Holbert [:dholbert]]

(In reply to Daniel Holbert [:dholbert] from comment #0)
> (That Try run includes a s/static/inline/ hack to disable the aforementioned
> warning from bug 962693)

(er, correction: looks like I actually hacked around it in that Try run by commenting out the function)

Comment 3

[Brian Smith (:briansmith, :bsmith, use NEEDINFO?)]

Comment on attachment 8371070 [details] [diff] [review]
fix

Review of attachment 8371070 [details] [diff] [review]:
-----------------------------------------------------------------

NIT: please use r=briansmith in the commit message.

Thanks for this, and thanks for clarifying how FAIL_ON_WARNINGS works.

Comment 4

[Daniel Holbert [:dholbert]]

Will do. Thanks!

Comment 5

[Camilo Viecco (:cviecco)]

Attachment: add-ifdef-to-allow-warning-free-compile

Comment 6

[Daniel Holbert [:dholbert]]

Comment on attachment 8371093 [details] [diff] [review]
add-ifdef-to-allow-warning-free-compile

per IRL conversation with cviecco: I'll land this with rs=me (to fix the build warning), on the understanding that this code won't remain #ifdeffed out for too long.

Comment 7

[Brian Smith (:briansmith, :bsmith, use NEEDINFO?)]

Comment on attachment 8371093 [details] [diff] [review]
add-ifdef-to-allow-warning-free-compile

Review of attachment 8371093 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks.

Comment 8

[Daniel Holbert [:dholbert]]

or better, I'll land it with r=briansmith :)

Comment 9

[Daniel Holbert [:dholbert]]

Sanity-check Try run, with these patches and a few others:
 https://tbpl.mozilla.org/?tree=Try&rev=b19e92decdb9

Comment 10

[Daniel Holbert [:dholbert]]

(The build error in that Try run is from bug 968323's patch being not-quite-complete. I'll fix & re-Try, and then push if all is well.)

Comment 11

[Daniel Holbert [:dholbert]]

New Try run with that fixed: https://tbpl.mozilla.org/?tree=Try&rev=3b48dd15290d

Comment 12

[Daniel Holbert [:dholbert]]

Landed Camilo's helper-patch: https://hg.mozilla.org/integration/mozilla-inbound/rev/98236f59f6f9
and the FAIL_ON_WARNINGS patch: https://hg.mozilla.org/integration/mozilla-inbound/rev/b0854f873c68

Comment 13

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/98236f59f6f9
https://hg.mozilla.org/mozilla-central/rev/b0854f873c68