Remove ContentParent's phone-state-changed observer

VERIFIED FIXED in Firefox 30, Firefox OS v1.3

Status

()

Core
IPC
VERIFIED FIXED
5 years ago
4 years ago

People

(Reporter: khuey, Assigned: khuey)

Tracking

({memory-leak})

unspecified
mozilla30
memory-leak
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(blocking-b2g:1.3+, firefox28 wontfix, firefox29 wontfix, firefox30 fixed, b2g-v1.1hd unaffected, b2g-v1.2 wontfix, b2g-v1.3 fixed, b2g-v1.3T fixed, b2g-v1.4 fixed)

Details

Attachments

(1 attachment)

Created attachment 8371123 [details] [diff] [review]
Patch

I should have caught this in review :(  This means we leak every ContentParent ever.  It affects 1.2 too.
Attachment #8371123 - Flags: review?(n.nethercote)
Comment on attachment 8371123 [details] [diff] [review]
Patch

Review of attachment 8371123 [details] [diff] [review]:
-----------------------------------------------------------------

r=me, but even better would be if you create an array of observer topic strings, and change ContentParent::Init() and ContentParent::ActorDestroy() to iterate over them. That would make it impossible for the additions and removals to not match.
Attachment #8371123 - Flags: review?(n.nethercote) → review+
That's a great idea.  Let's do that in a followup so that we don't need to land churn on 1.3.
https://hg.mozilla.org/mozilla-central/rev/4765c5eddf20
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla30
https://hg.mozilla.org/releases/mozilla-b2g28_v1_3/rev/cc08d5515dab
status-b2g-v1.2: affected → wontfix
status-b2g-v1.3: affected → fixed
status-b2g-v1.4: --- → fixed
status-firefox28: --- → wontfix
status-firefox29: --- → wontfix
status-firefox30: --- → fixed
I verified this is fixed. See bug 963290 comment 24.
Status: RESOLVED → VERIFIED
status-b2g-v1.3T: --- → fixed
You need to log in before you can comment on or make changes to this bug.