968536 - Remove ContentParent's phone-state-changed observer

Status: VERIFIED FIXED

(Core :: IPC, defect)

Description

[Kyle Huey (Exited; not receiving bugmail, old account, do not use)]

Attachment: Patch

I should have caught this in review :(  This means we leak every ContentParent ever.  It affects 1.2 too.

Comment 1

[Nicholas Nethercote [inactive]]

Comment on attachment 8371123 [details] [diff] [review]
Patch

Review of attachment 8371123 [details] [diff] [review]:
-----------------------------------------------------------------

r=me, but even better would be if you create an array of observer topic strings, and change ContentParent::Init() and ContentParent::ActorDestroy() to iterate over them. That would make it impossible for the additions and removals to not match.

Comment 2

[Kyle Huey (Exited; not receiving bugmail, old account, do not use)]

That's a great idea.  Let's do that in a followup so that we don't need to land churn on 1.3.

Comment 3

[Kyle Huey (Exited; not receiving bugmail, old account, do not use)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/4765c5eddf20

Comment 4

[Kyle Huey (Exited; not receiving bugmail, old account, do not use)]

I filed bug 970821.

Comment 5

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/4765c5eddf20

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-b2g28_v1_3/rev/cc08d5515dab

Comment 7

[Nicholas Nethercote [inactive]]

I verified this is fixed. See bug 963290 comment 24.