Closed
Bug 968537
Opened 11 years ago
Closed 11 years ago
Build js-config from configure instead of Makefile
Categories
(Firefox Build System :: General, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
mozilla30
People
(Reporter: glandium, Assigned: glandium)
References
(Blocks 1 open bug)
Details
Attachments
(1 file)
7.68 KB,
patch
|
ted
:
review+
|
Details | Diff | Splinter Review |
To help with the incremental merge of the js/src build system with toplevel, js's configure needs not to run make, which it currently does to create js-config.
Assignee | ||
Comment 1•11 years ago
|
||
Note this does change the ldflags exposed by both js-config and js.pc, but also note that the current values they expose are currently completely wrong (like, they include -Wl,--version-script)
Attachment #8371125 -
Flags: review?(ted)
Comment 2•11 years ago
|
||
Comment on attachment 8371125 [details] [diff] [review] Build js-config from configure instead of Makefile Review of attachment 8371125 [details] [diff] [review]: ----------------------------------------------------------------- ::: js/src/Makefile.in @@ +291,4 @@ > SCRIPTS = $(JS_CONFIG_NAME) > SDK_BINARY = $(JS_CONFIG_NAME) > > +$(LIBRARY_NAME).pc: js.pc Can we just output these both during configure?
Attachment #8371125 -
Flags: review?(ted) → review+
Assignee | ||
Comment 3•11 years ago
|
||
(In reply to Ted Mielczarek [:ted.mielczarek] from comment #2) > > +$(LIBRARY_NAME).pc: js.pc > > Can we just output these both during configure? We don't have stuff to say "create this file from that other .in file" yet. And I (obviously) don't want to add a Preprocessor command in configure itself. I think we'll eventually want something for "create this file from that other .in file" things, so let's just wait for that.
Assignee | ||
Comment 4•11 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/9468c7f9fe8d
Comment 5•11 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/9468c7f9fe8d
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla30
Updated•6 years ago
|
Product: Core → Firefox Build System
You need to log in
before you can comment on or make changes to this bug.
Description
•