968616 - Hide the explicitly broken things we do for testing from the hazard analysis

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Description

[Terrence Cole [:terrence]]

Attachment: hide_gcstorebufferremoval_test_from_analysis-v0.diff

The analysis will just freak out if it sees this code, so why tell it? I won't it if you won't.

I'm not sure if this is exactly the best way to hide code from the analysis, but I figure it should work considering it "worked" in other parts of the browser.

Comment 1

[Steve Fink [:sfink] [:s:]]

Comment on attachment 8371212 [details] [diff] [review]
hide_gcstorebufferremoval_test_from_analysis-v0.diff

Review of attachment 8371212 [details] [diff] [review]:
-----------------------------------------------------------------

You're going to be reincarnated as a hagfish for this one. http://bio.fsu.edu/~bsc2011l/graphics/Kingdom_Animalia/5_Eucoelomates/phylum_chordata/agnatha_hagfish.jpg

r=me, though really we should make an AutoLieAndClaimNoGC RAII object and have the analysis treat it as if it were an AutoAssertNoGC. AutoHideGCFromAnalysis?

Comment 2

[Terrence Cole [:terrence]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/59230a163ec0

Comment 3

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/59230a163ec0

Comment 4

[Terrence Cole [:terrence]]

The analysis was not fooled by our ball-and-cup game. Soon it will be as smart as a cat.

Comment 5

[Steve Fink [:sfink] [:s:]]

Attachment: "Implement" AutoIgnoreRootingHazards

Attempt 2

Comment 6

[Terrence Cole [:terrence]]

Comment on attachment 8377869 [details] [diff] [review]
"Implement" AutoIgnoreRootingHazards

Review of attachment 8377869 [details] [diff] [review]:
-----------------------------------------------------------------

Nice! That was more straightforward than I thought it would be. r=me

Comment 7

[Steve Fink [:sfink] [:s:]]

Attachment: "Implement" AutoIgnoreRootingHazards

This one actually works. https://tbpl.mozilla.org/?tree=Try&rev=8a8ee5bf142d

Comment 8

[Terrence Cole [:terrence]]

Comment on attachment 8378553 [details] [diff] [review]
"Implement" AutoIgnoreRootingHazards

Review of attachment 8378553 [details] [diff] [review]:
-----------------------------------------------------------------

Oh, that's awful, but it does fit right it with the rest of the test now, so r=me.

Comment 9

[Steve Fink [:sfink] [:s:]]

http://hg.mozilla.org/integration/mozilla-inbound/rev/7f6f5e970345

Comment 10

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/7f6f5e970345