Closed Bug 968635 Opened 6 years ago Closed 6 years ago

build bustage using clang & --enable-warnings-as-errors: "TextureClientX11.h:59:16: error: private field 'mTextureFlags' is not used [-Werror,-Wunused-private-field]"

Categories

(Core :: Graphics: Layers, defect)

x86_64
Linux
defect
Not set

Tracking

()

RESOLVED FIXED
mozilla30

People

(Reporter: dholbert, Assigned: billm)

References

(Blocks 1 open bug)

Details

Attachments

(1 file, 2 obsolete files)

Bug 947045 just landed on inbound, adding ./gfx/layers/basic/TextureClientX11.h, and seems to have caused this build bustage on my local machine with clang++ and ac_add_options --enable-warnings-as-errors:
{
gfx/layers/basic/TextureClientX11.cpp:5:
../../dist/include/mozilla/layers/TextureClientX11.h:59:16: error: private field 'mTextureFlags' is not used [-Werror,-Wunused-private-field]
}

Maybe we can just drop that variable?
Summary: build bustage using clang & --enable-warnings-as-errors, with "TextureClientX11.h:59:16: error: private field 'mTextureFlags' is not used [-Werror,-Wunused-private-field]" → build bustage using clang & --enable-warnings-as-errors: "TextureClientX11.h:59:16: error: private field 'mTextureFlags' is not used [-Werror,-Wunused-private-field]"
(In reply to Daniel Holbert [:dholbert] from comment #0)
> Maybe we can just drop that variable?

Looking at the patch, attachment 8370505 [details] [diff] [review], it looks like we can just drop it (and the constructor-param "aFlags" along with it).

Bill, would that make sense?
Flags: needinfo?(wmccloskey)
(or alternately, maybe we really should be checking this variable but aren't?)
It seems like we ought to be able to take it out, but I don't know this code very well. Let's ask Matt.
Flags: needinfo?(wmccloskey) → needinfo?(matt.woodrow)
Here's a strawman patch to drop the variable, per comment 1.

(Even if this isn't what we want, this can serve as a local hackaround for anyone else who's running into this, in the meantime.)
Attachment #8371243 - Flags: review?(matt.woodrow)
Comment on attachment 8371243 [details] [diff] [review]
strawman (and/or local hackaround): drop the variable

(er, never mind about this exact patch; my build failed when it got to CompositableClient.cpp, which invokes the constructor with an explicit flags arg)
Attachment #8371243 - Attachment is obsolete: true
Attachment #8371243 - Flags: review?(matt.woodrow)
Attached patch strawman/hackaround (obsolete) — Splinter Review
(here's a working hackaround, not modifying the constructor this time)
This was actually a real bug. We need to set the flags in the base class.
Assignee: nobody → wmccloskey
Attachment #8371268 - Attachment is obsolete: true
Status: NEW → ASSIGNED
Attachment #8372954 - Flags: review?(matt.woodrow)
Flags: needinfo?(matt.woodrow)
Attachment #8372954 - Flags: review?(matt.woodrow) → review+
https://hg.mozilla.org/mozilla-central/rev/b673cf81b9e5
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla30
You need to log in before you can comment on or make changes to this bug.