968648 - JavaScript Warning: "ReferenceError: reference to undefined property next.tagName"

Status: RESOLVED WORKSFORME

(Toolkit :: Reader Mode, defect)

Description

[Kelsey Gilbert [:jgilbert]]

I saw this spew go by in my DEBUG android build on my Nexus 4:

[JavaScript Warning: "ReferenceError: reference to undefined property next.tagName" {file: "chrome://browser/content/Readability.js" line: 262}]

[JavaScript Warning: "ReferenceError: reference to undefined property next.tagName" {file: "chrome://browser/content/Readability.js" line: 346}]

Comment 1

[sbose78]

Need some direction from dev:

Was planning to take this. However, hitting chrome://browser/content/Readability.js in the browser yields a 404.

where should I be looking for this file Readability.js in the source code?
I couldn't find it under mobile/android/chrome/content/


Thanks,
Shoubhik

Comment 2

[:Margaret Leibovic]

Ah, sorry, this code moved since this bug was filed. You can now find the file here:
http://mxr.mozilla.org/mozilla-central/source/toolkit/components/reader/content/Readability.js

Comment 3

[Tim Guan-tin Chien [:timdream] (please needinfo)]

... and it was moved again to https://dxr.mozilla.org/mozilla-central/source/toolkit/components/reader/Readability.js

Comment 4

[:Gijs (he/him)]

Fairly sure this has been fixed already. looking for next.tagName in Readability.js, all usecases are using checks to see that the next node is an Element, and those should have a tagName. Going to resolve as WFM, we should reopen if there are clear steps that still produce this issue.