968657 - Add |make watch| to monitor files change and build for specific app.

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Build, defect)

Description

[Yuren [:yurenju] (AFK ~ Oct. 12) (volunteer mode)]

after bug 897352 land, all apps will be assembled in build_stage directory, we should have a monitor feature to detect file change and build for specific app.

when user execute |make monitor|, build system will build a gaia profile and monitor file change, if user change GAIA_DIR/apps/homescreen/js/grid.js, |APP=homescreen make| will be executed.

Comment 1

[Greg Weng [:snowmantw][:gweng][:λ]]

I've a almost done patch for this, so I take it now.

Comment 2

[Greg Weng [:snowmantw][:gweng][:λ]]

Attachment: WIP Patch

This WIP patch works, but it still lacks:

1. Windows' separator should be considered in the parsePath function
2. Even after the make, some files (multi-localization related) still be changed and thus would cause a infinite make. I use 5 secs to wait them to avoid the problem.

I may spend sometimes to fix these bugs in the future.

Comment 3

[Yuren [:yurenju] (AFK ~ Oct. 12) (volunteer mode)]

Comment on attachment 8372114 [details] [review]
WIP Patch

Great! there are to suggestions:
1. LOCALE_BASEDIR should also be monitored for l10n, we could have a argument to change listening directory.
2. watcher.js should be tested, we can use |make build-test-unit| to test build module, please check GAIA_DIR/build/test/unit/ for it.

Comment 4

[Greg Weng [:snowmantw][:gweng][:λ]]

Attachment: Patch

The patch. Added tests and other minor fixes.

Comment 5

[Greg Weng [:snowmantw][:gweng][:λ]]

Travis was green: https://travis-ci.org/mozilla-b2g/gaia/builds/18566246

Comment 6

[Yuren [:yurenju] (AFK ~ Oct. 12) (volunteer mode)]

Comment on attachment 8373183 [details] [review]
Patch

r=yurenju if nits is addressed, thank you Greg!

Comment 7

[Greg Weng [:snowmantw][:gweng][:λ]]

The Travis failed at a totally irrelevant test.
So I want to merge it.

https://travis-ci.org/mozilla-b2g/gaia/jobs/18704279

Comment 8

[Greg Weng [:snowmantw][:gweng][:λ]]

master: https://github.com/mozilla-b2g/gaia/commit/f4f68e9942feada3fcc12c74c6023f0b17b726d2