Get rid of MainThreadDictionaryBase

RESOLVED FIXED in mozilla30

Status

()

Core
DOM
RESOLVED FIXED
4 years ago
4 years ago

People

(Reporter: bz, Assigned: bz)

Tracking

unspecified
mozilla30
x86
Mac OS X
Points:
---
Bug Flags:
in-testsuite -

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

All dictionaries inherit from it, since we no longer have separate mainthread and worker dictionaries.
Also, going to nix the dictionary bits from DummyBinding... plus the other accumulated cruft it has that's no longer needed.  For example, the EventTarget inheritance is not needed now that Window.webidl exists.  And the various callbacks shown there are actually used in IDL, so don't need to be in DummyBinding anymore.
Created attachment 8371270 [details] [diff] [review]
Get rid of MainThreadDictionaryBase and the dictionary bits in DummyBinding, since we now codegen a single version of dictionaries for both mainthread and workers.
Attachment #8371270 - Flags: review?(khuey)
Comment on attachment 8371270 [details] [diff] [review]
Get rid of MainThreadDictionaryBase and the dictionary bits in DummyBinding, since we now codegen a single version of dictionaries for both mainthread and workers.

Review of attachment 8371270 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/bindings/BindingDeclarations.h
@@ +36,5 @@
>  // so we can use IsBaseOf to detect dictionary template arguments.
>  struct DictionaryBase
>  {
> +protected:
> +  bool ParseJSON(JSContext *aCx, const nsAString& aJSON,

* to the left while you're here

::: dom/bindings/BindingUtils.cpp
@@ +1528,5 @@
>    }
>  }
>  
>  bool
> +DictionaryBase::ParseJSON(JSContext *aCx,

Ditto
Is DummyBinding itself still needed?
Right this moment no, but I'd rather not rip it out in case someone adds another callback they need to add there...
https://hg.mozilla.org/integration/mozilla-inbound/rev/0e28e7bc8b05 with the '*' nits.
Flags: in-testsuite-
Whiteboard: [need review]
Target Milestone: --- → mozilla30
https://hg.mozilla.org/mozilla-central/rev/0e28e7bc8b05
Status: NEW → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.