968716 - B2G RIL: JavaScript Error: "Unknown rilSuppSvcNotification: null"

Status: RESOLVED FIXED

(Firefox OS Graveyard :: RIL, defect)

Description

[Edgar Chen [:edgar]]

Found below javascript error when having a MO call.
--
02-06 11:58:11.302   108   108 E GeckoConsole: [JavaScript Error: "Unknown rilSuppSvcNotification: null" {file: "jar:file:///system/b2g/omni.ja!/components/TelephonyProvider.js" line: 318}]
02-06 11:58:11.302   108   108 E GeckoConsole: [JavaScript Error: "NS_ERROR_XPC_JAVASCRIPT_ERROR_WITH_DETAILS: [JavaScript Error: "Unknown rilSuppSvcNotification: null" {file: "jar:file:///system/b2g/omni.ja!/components/TelephonyProvider.js" line: 318}]'[JavaScript Error: "Unknown rilSuppSvcNotification: null" {file: "jar:file:///system/b2g/omni.ja!/components/TelephonyProvider.js" line: 318}]' when calling method: [nsIGonkTelephonyProvider::notifySupplementaryService]" {file: "jar:file:///system/b2g/omni.ja!/components/RadioInterfaceLayer.js" line: 1485}]
--

Build info:
- Device: unagi
- Gecko: 166803:2c366892729d (m-c)
- Gaia: e6b5fc463f060 (master)

Comment 1

[Edgar Chen [:edgar]]

Attachment: unagi_svc_error.txt

02-06 11:58:11.302   108   108 E GeckoConsole: [JavaScript Error: "Unknown rilSuppSvcNotification: null" {file: "jar:file:///system/b2g/omni.ja!/components/TelephonyProvider.js" line: 318}]
02-06 11:58:11.302   108   108 E GeckoConsole: [JavaScript Error: "NS_ERROR_XPC_JAVASCRIPT_ERROR_WITH_DETAILS: [JavaScript Error: "Unknown rilSuppSvcNotification: null" {file: "jar:file:///system/b2g/omni.ja!/components/TelephonyProvider.js" line: 318}]'[JavaScript Error: "Unknown rilSuppSvcNotification: null" {file: "jar:file:///system/b2g/omni.ja!/components/TelephonyProvider.js" line: 318}]' when calling method: [nsIGonkTelephonyProvider::notifySupplementaryService]" {file: "jar:file:///system/b2g/omni.ja!/components/RadioInterfaceLayer.js" line: 1485}]

Comment 2

[Hsin-Yi Tsai (she/her) [:hsinyi]]

(In reply to Edgar Chen [:edgar][:echen] from comment #1)
> Created attachment 8371304 [details]
> unagi_svc_error.txt
> 
> 02-06 11:58:11.302   108   108 E GeckoConsole: [JavaScript Error: "Unknown
> rilSuppSvcNotification: null" {file:
> "jar:file:///system/b2g/omni.ja!/components/TelephonyProvider.js" line: 318}]
> 02-06 11:58:11.302   108   108 E GeckoConsole: [JavaScript Error:
> "NS_ERROR_XPC_JAVASCRIPT_ERROR_WITH_DETAILS: [JavaScript Error: "Unknown
> rilSuppSvcNotification: null" {file:
> "jar:file:///system/b2g/omni.ja!/components/TelephonyProvider.js" line:
> 318}]'[JavaScript Error: "Unknown rilSuppSvcNotification: null" {file:
> "jar:file:///system/b2g/omni.ja!/components/TelephonyProvider.js" line:
> 318}]' when calling method:
> [nsIGonkTelephonyProvider::notifySupplementaryService]" {file:
> "jar:file:///system/b2g/omni.ja!/components/RadioInterfaceLayer.js" line:
> 1485}]

Thanks for reporting this, Edgar.

Actually, it's not a bug. We haven't had a full support for any kind of supplementary service notification. That's why we see |"Unknown rilSuppSvcNotification: null"| Thought it's not a real bug, the message looks scaring. I think we could have a softer warning instead of throwing a js error. :)

Comment 3

[Hsin-Yi Tsai (she/her) [:hsinyi]]

Attachment: 968716.patch - v1

Avoid redundant execution for unsupported notification type

Comment 4

[Szu-Yu Chen [:aknow] (inactive)]

Comment on attachment 8371344 [details] [diff] [review]
968716.patch - v1

Review of attachment 8371344 [details] [diff] [review]:
-----------------------------------------------------------------

I think the patch didn't resolve the problem.
We could simply add a 'return' for MO type notification.

::: dom/system/gonk/ril_worker.js
@@ -3815,5 @@
>      let callIndex = -1;
>  
> -    if (info.notificationType === 0) {
> -      // MO intermediate result code. Refer to code1 defined in 3GPP 27.007
> -      // 7.17.

How about just add a 'return;' here

Comment 5

[Hsin-Yi Tsai (she/her) [:hsinyi]]

(In reply to Szu-Yu Chen [:aknow] from comment #4)
> Comment on attachment 8371344 [details] [diff] [review]
> 968716.patch - v1
> 
> Review of attachment 8371344 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> I think the patch didn't resolve the problem.
> We could simply add a 'return' for MO type notification.
> 
> ::: dom/system/gonk/ril_worker.js
> @@ -3815,5 @@
> >      let callIndex = -1;
> >  
> > -    if (info.notificationType === 0) {
> > -      // MO intermediate result code. Refer to code1 defined in 3GPP 27.007
> > -      // 7.17.
> 
> How about just add a 'return;' here

'return;' is one option. If you do want to indicate there is a type we have NOT supported so far from code, then we could do it. I remove it completely because I'd like to show the type we HAVE supported.

Comment 6

[Hsin-Yi Tsai (she/her) [:hsinyi]]

(In reply to Hsin-Yi Tsai  [:hsinyi] from comment #5)
> (In reply to Szu-Yu Chen [:aknow] from comment #4)
> > Comment on attachment 8371344 [details] [diff] [review]
> > 968716.patch - v1
> > 
> > Review of attachment 8371344 [details] [diff] [review]:
> > -----------------------------------------------------------------
> > 
> > I think the patch didn't resolve the problem.
> > We could simply add a 'return' for MO type notification.
> > 
> > ::: dom/system/gonk/ril_worker.js
> > @@ -3815,5 @@
> > >      let callIndex = -1;
> > >  
> > > -    if (info.notificationType === 0) {
> > > -      // MO intermediate result code. Refer to code1 defined in 3GPP 27.007
> > > -      // 7.17.
> > 
> > How about just add a 'return;' here
> 
> 'return;' is one option. If you do want to indicate there is a type we have
> NOT supported so far from code, then we could do it. I remove it completely
> because I'd like to show the type we HAVE supported.

oops... my bad...

Comment 7

[Hsin-Yi Tsai (she/her) [:hsinyi]]

Attachment: 968716-v2.patch

Review comment addressed.

Comment 8

[Szu-Yu Chen [:aknow] (inactive)]

Comment on attachment 8372018 [details] [diff] [review]
968716-v2.patch

Review of attachment 8372018 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/system/gonk/ril_worker.js
@@ +3811,5 @@
>        debug("handle supp svc notification: " + JSON.stringify(info));
>      }
>  
>      let notification = null;
>      let callIndex = -1;

I would like to move these two lines to the location after next 'if' block (line: 3824)

Comment 9

[Hsin-Yi Tsai (she/her) [:hsinyi]]

Local manual and marionette tests pass!

Comment 8 addressed: https://hg.mozilla.org/integration/b2g-inbound/rev/f61d9d4cd37f

Comment 10

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/f61d9d4cd37f