Closed
Bug 968735
Opened 12 years ago
Closed 12 years ago
Misc tweaks in PanelsPreferenceCategory
Categories
(Firefox for Android Graveyard :: General, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
Firefox 30
People
(Reporter: lucasr, Assigned: lucasr)
Details
Attachments
(2 files)
|
1.41 KB,
patch
|
liuche
:
review+
|
Details | Diff | Splinter Review |
|
2.70 KB,
patch
|
liuche
:
review+
|
Details | Diff | Splinter Review |
What the summary says.
|
Assignee | |
Comment 1•12 years ago
|
||
|
|
Assignee | |
Comment 2•12 years ago
|
||
|
|
Assignee | |
Comment 3•12 years ago
|
||
Comment on attachment 8371339 [details] [diff] [review]
Rename displayPanelConfig() to displayHomeConfig() (r=liuche)
For consistency with loadHomeConfig() and saveHomeConfig()
Attachment #8371339 -
Flags: review?(liuche)
|
|
Assignee | |
Updated•12 years ago
|
Attachment #8371340 -
Flags: review?(liuche)
|
||
Comment 4•12 years ago
|
||
Comment on attachment 8371339 [details] [diff] [review]
Rename displayPanelConfig() to displayHomeConfig() (r=liuche)
Review of attachment 8371339 [details] [diff] [review]:
-----------------------------------------------------------------
lgtm
Attachment #8371339 -
Flags: review?(liuche) → review+
|
|
||
Comment 5•12 years ago
|
||
Comment on attachment 8371340 [details] [diff] [review]
Don't use 'm' prefix for non-member variables (r=liuche)
Review of attachment 8371340 [details] [diff] [review]:
-----------------------------------------------------------------
Looks good. Just so I get the convention - we want to use the 'm' prefix for member instances in a class; are there any other prefix conventions that we use?
Attachment #8371340 -
Flags: review?(liuche) → review+
|
|
Assignee | |
Comment 6•12 years ago
|
||
(In reply to Chenxia Liu [:liuche] from comment #5)
> Comment on attachment 8371340 [details] [diff] [review]
> Don't use 'm' prefix for non-member variables (r=liuche)
>
> Review of attachment 8371340 [details] [diff] [review]:
> -----------------------------------------------------------------
>
> Looks good. Just so I get the convention - we want to use the 'm' prefix for
> member instances in a class; are there any other prefix conventions that we
> use?
AFAIK, the only other prefix conversion is 's' for static class members.
|
|
Assignee | |
Comment 7•12 years ago
|
||
|
||
Comment 8•12 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/31b96e201b86
https://hg.mozilla.org/mozilla-central/rev/ea70f78db5f5
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 30
|
||
Updated•5 years ago
|
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•