968756 - Light theme buttons don't have an "active" state

Status: VERIFIED FIXED

(DevTools :: Console, defect)

Description

[Paul Rouget [:paul]]

Mousedown on a button (clear, js, …), the style of the button doesn't change.

Comment 1

[Brian Grinstead [:bgrins]]

I believe this is for all light theme buttons

Comment 2

[Brian Grinstead [:bgrins]]

We are going to be working on a bigger restyle of toolbar buttons in Bug 952100, but this is an easy enough fix there isn't really a reason to wait for that.  The only issue is that to get enough contrast between normal, :hover, hover:active, and [checked], we may need to make the checked state a bit darker.

Right now:

normal: #f7f7f7
checked: #ddd
hover: #eee

to squeeze :hover:active in between #eee and #ddd isn't going to be very different from one or the other.

Comment 3

[Brian Grinstead [:bgrins]]

Attachment: state-comparison.png

Comment 4

[Brian Grinstead [:bgrins]]

Attachment: light-theme-button-states.patch

What do you think?

Comment 5

[Brian Grinstead [:bgrins]]

https://hg.mozilla.org/integration/fx-team/rev/6c1d05889bc8
https://tbpl.mozilla.org/?tree=Fx-Team&rev=6c1d05889bc8

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/6c1d05889bc8

Comment 7

[Brian Grinstead [:bgrins]]

Comment on attachment 8371454 [details] [diff] [review]
light-theme-button-states.patch

[Approval Request Comment]
Bug caused by (feature/regressing bug #): 957117
User impact if declined: Buttons in DevTools light theme will not have an active state
Testing completed (on m-c, etc.): On m-c since 2-06
Risk to taking this patch (and alternatives if risky): Low risk - CSS only change in DevTools
String or IDL/UUID changes made by this patch:

Comment 8

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/8a672612d3ac

Comment 9

[Tracy Walker [:tracy]]

Verified with latest builds of Nightly and Aurora