Closed
Bug 968769
Opened 11 years ago
Closed 11 years ago
Remove data_layer and accessibility from base.py's init
Categories
(Firefox OS Graveyard :: Gaia::UI Tests, defect, P3)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: zcampbell, Assigned: Bebe)
Details
Attachments
(1 file)
The data_layer class and accessibility class are only used in one app object, yet it is initialised every time we initialise a new app object which may be hundreds of times in a test run.
We could reduce this by only initialising them in the app object it is used.
Most of the time self.data_layer is used directly in the test instead.
|
Assignee | |
Updated•11 years ago
|
Assignee: nobody → florin.strugariu
Status: NEW → ASSIGNED
|
|
Assignee | |
Comment 1•11 years ago
|
||
Attachment #8371457 -
Flags: review?(zcampbell)
Attachment #8371457 -
Flags: review?(viorela.ioia)
Attachment #8371457 -
Flags: review?(andrei.hutusoru)
|
Reporter | |
Comment 2•11 years ago
|
||
Comment on attachment 8371457 [details] [review]
Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/16037
Travis is green but just some pep8 regression crept in.
Attachment #8371457 -
Flags: review?(zcampbell)
Attachment #8371457 -
Flags: review?(viorela.ioia)
Attachment #8371457 -
Flags: review?(andrei.hutusoru)
Attachment #8371457 -
Flags: review-
|
|
Assignee | |
Updated•11 years ago
|
Attachment #8371457 -
Flags: review- → review?(zcampbell)
|
|
Reporter | |
Comment 3•11 years ago
|
||
Comment on attachment 8371457 [details] [review]
Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/16037
nice!
Attachment #8371457 -
Flags: review?(zcampbell) → review+
|
|
Reporter | |
Comment 4•11 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•