968778 - [browser] "Cancel" is hard-coded in the dialog appearing when long tapping on a link

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::Browser, defect)

Description

[Iacopo Benesperi [:iacchi]]

I don't know if the string is not localised or not localisable (I think the second case, but I'll let Francesco tell which is the right one), but here's how to reproduce:

1. Open a web page with a link
2. Tap and keep tapping on the link
3. In the page where you can choose to open the link in a new tab, the cancel button string is "Cancel" instead of "Annulla"

Comment 1

[Iacopo Benesperi [:iacchi]]

Sorry, I forgot: test phone: GP Keon, FFOS 1.3, build date 04/02/2014

Comment 2

[Francesco Lodolo [:flod]]

I can reproduce (not on 1.4, since browser is no more).

My first guess is that's a Gecko string, so I can't translate it. 

I'm trying to look at the code to figure it out but it's quite hard
https://github.com/mozilla-b2g/gaia/blob/master/apps/browser/js/browser.js#L1044

Comment 3

[Francesco Lodolo [:flod]]

Looks hard-coded
https://github.com/mozilla-b2g/gaia/blob/master/apps/browser/js/browser.js#L1143

> cancel.appendChild(this.createButton('Cancel'));

Comment 4

[Francesco Lodolo [:flod]]

Attachment: Wrap "Cancel" in l10n call to display it localized

Comment 5

[Francesco Lodolo [:flod]]

Attachment: Screenshot with patch applied

"Cancel" is correctly localized using the string already existing in browser.properties

Comment 6

[Francesco Lodolo [:flod]]

Setting 1.3?, since since this patch fixes a l10n problem without actually adding new strings.

Comment 7

[Ben Francis [:benfrancis]]

Merged into master https://github.com/mozilla-b2g/gaia/commit/b374f60685d624008bb55b50f0127136493d221b

Comment 8

[John Ford [:jhford] CET/CEST Berlin Time]

Uplifted b374f60685d624008bb55b50f0127136493d221b to:
v1.3: 741869c9f0eaae242351f312c18fa6051715c086

Comment 9

[Francesco Lodolo [:flod]]

Verified on Keon master (1.4 2014-03-01 git commit f6f23511).