968804 - Add some more inner/outer window assertions

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Comment 1

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

Attachment: Part a: DETH and {Add,Remove}EventTargetObject

Comment 2

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

Attachment: Part b: {Can,Force,Final}Close

Comment 3

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

Attachment: Part c: WouldReuseInnerWindow

Comment 4

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

Attachment: Part d: SetInitialPrincipalToSubject

Comment 5

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

Attachment: Part e: PreloadLocalStorage

Comment 6

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

Attachment: Part f: DispatchDOMWindowCreated

Comment 7

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

Attachment: Part g: AreDialogsEnabled

Comment 8

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

Attachment: Part h: DefineArgumentsProperty

Comment 9

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

Attachment: Part i: AudioContexts

Comment 10

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

Attachment: Part j: CreatePerformanceObjectIfNeeded

Comment 11

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

Attachment: Part k: GetScrollXY

Comment 12

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

Attachment: Part l: DispatchResizeEvent

Comment 13

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

Attachment: Part m: DispatchCustomEvent

Comment 14

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

Attachment: Part n: Split nsGlobalWindow::GetFullScreen into a forwarding and an assertion part

Comment 15

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

Attachment: Part o: RefreshCompartmentPrincipal

Comment 16

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

Attachment: Part p: SetFullScreenInternal

Comment 17

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

Attachment: Part q: Gamepad-related methods

Comment 18

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

Attachment: Part r: SetArguments

Comment 19

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

Attachment: Part s: CloneStorageEvent

Comment 20

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

Attachment: Part t: OpenNoNavigate

Comment 21

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

Attachment: Part u: OpenInternal

Comment 22

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/f5c8ca9dbaf6
https://hg.mozilla.org/integration/mozilla-inbound/rev/ee7682771589
https://hg.mozilla.org/integration/mozilla-inbound/rev/b781793ab79f
https://hg.mozilla.org/integration/mozilla-inbound/rev/e5a6f6fb6db3
https://hg.mozilla.org/integration/mozilla-inbound/rev/11cb08d1670c
https://hg.mozilla.org/integration/mozilla-inbound/rev/f0a563b325eb
https://hg.mozilla.org/integration/mozilla-inbound/rev/c160e03f2a4f

Comment 23

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/f5c8ca9dbaf6
https://hg.mozilla.org/mozilla-central/rev/ee7682771589
https://hg.mozilla.org/mozilla-central/rev/b781793ab79f
https://hg.mozilla.org/mozilla-central/rev/e5a6f6fb6db3
https://hg.mozilla.org/mozilla-central/rev/11cb08d1670c
https://hg.mozilla.org/mozilla-central/rev/f0a563b325eb
https://hg.mozilla.org/mozilla-central/rev/c160e03f2a4f

Comment 24

[Kyle Huey (Exited; not receiving bugmail, old account, do not use)]

Comment on attachment 8371489 [details] [diff] [review]
Part k: GetScrollXY

Review of attachment 8371489 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/base/nsGlobalWindow.h
@@ +1195,5 @@
>  
>    // If aDoFlush is true, we'll flush our own layout; otherwise we'll try to
>    // just flush our parent and only flush ourselves if we think we need to.
> +  // Outer windows only.
> +  mozilla::CSSIntPoint GetScrollXY(bool aDoFlush);

I would say rename this to ScrollXY, but it seems odd to have a getter with a verb for a name :/

Comment 25

[Kyle Huey (Exited; not receiving bugmail, old account, do not use)]

Comment on attachment 8391721 [details] [diff] [review]
Part n: Split nsGlobalWindow::GetFullScreen into a forwarding and an assertion part

Review of attachment 8391721 [details] [diff] [review]:
-----------------------------------------------------------------

You ought to be able to assert that the XPCOM version of GetFullScreen is only ever called on an outer, no?

Comment 26

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

(In reply to Kyle Huey [:khuey] ([e-mail]) from comment #25)
> Comment on attachment 8391721 [details] [diff] [review]
> Part n: Split nsGlobalWindow::GetFullScreen into a forwarding and an
> assertion part
> 
> Review of attachment 8391721 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> You ought to be able to assert that the XPCOM version of GetFullScreen is
> only ever called on an outer, no?

Maybe, but I'm not comfortable doing that.

Comment 27

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/287f17ee7052
https://hg.mozilla.org/integration/mozilla-inbound/rev/be27b3a36983
https://hg.mozilla.org/integration/mozilla-inbound/rev/473ab7b769a0
https://hg.mozilla.org/integration/mozilla-inbound/rev/947fa1643644
https://hg.mozilla.org/integration/mozilla-inbound/rev/770ebe23e2f5
https://hg.mozilla.org/integration/mozilla-inbound/rev/26c2f6a41e3f
https://hg.mozilla.org/integration/mozilla-inbound/rev/e6537268dd26
https://hg.mozilla.org/integration/mozilla-inbound/rev/ca3722558673
https://hg.mozilla.org/integration/mozilla-inbound/rev/47514dfbd8d6
https://hg.mozilla.org/integration/mozilla-inbound/rev/f62480eb6d84
https://hg.mozilla.org/integration/mozilla-inbound/rev/ef9e5ce247d7
https://hg.mozilla.org/integration/mozilla-inbound/rev/c64a19d996cb
https://hg.mozilla.org/integration/mozilla-inbound/rev/2cac985638c2
https://hg.mozilla.org/integration/mozilla-inbound/rev/48ad95c9ad89

Comment 28

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/287f17ee7052
https://hg.mozilla.org/mozilla-central/rev/be27b3a36983
https://hg.mozilla.org/mozilla-central/rev/473ab7b769a0
https://hg.mozilla.org/mozilla-central/rev/947fa1643644
https://hg.mozilla.org/mozilla-central/rev/770ebe23e2f5
https://hg.mozilla.org/mozilla-central/rev/26c2f6a41e3f
https://hg.mozilla.org/mozilla-central/rev/e6537268dd26
https://hg.mozilla.org/mozilla-central/rev/ca3722558673
https://hg.mozilla.org/mozilla-central/rev/47514dfbd8d6
https://hg.mozilla.org/mozilla-central/rev/f62480eb6d84
https://hg.mozilla.org/mozilla-central/rev/ef9e5ce247d7
https://hg.mozilla.org/mozilla-central/rev/c64a19d996cb
https://hg.mozilla.org/mozilla-central/rev/2cac985638c2
https://hg.mozilla.org/mozilla-central/rev/48ad95c9ad89