Closed Bug 968804 Opened 7 years ago Closed 7 years ago

Add some more inner/outer window assertions

Categories

(Core :: DOM: Core & HTML, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla33

People

(Reporter: Ms2ger, Assigned: Ms2ger)

References

Details

Attachments

(21 files)

5.07 KB, patch
peterv
: review+
Details | Diff | Splinter Review
6.23 KB, patch
peterv
: review+
Details | Diff | Splinter Review
2.54 KB, patch
peterv
: review+
Details | Diff | Splinter Review
2.54 KB, patch
peterv
: review+
Details | Diff | Splinter Review
1.45 KB, patch
peterv
: review+
Details | Diff | Splinter Review
1.69 KB, patch
peterv
: review+
Details | Diff | Splinter Review
1.35 KB, patch
peterv
: review+
Details | Diff | Splinter Review
1.49 KB, patch
khuey
: review+
Details | Diff | Splinter Review
2.09 KB, patch
khuey
: review+
Details | Diff | Splinter Review
1.61 KB, patch
khuey
: review+
Details | Diff | Splinter Review
3.33 KB, patch
khuey
: review+
Details | Diff | Splinter Review
3.05 KB, patch
khuey
: review+
Details | Diff | Splinter Review
6.67 KB, patch
khuey
: review+
Details | Diff | Splinter Review
2.75 KB, patch
khuey
: review+
Details | Diff | Splinter Review
2.52 KB, patch
khuey
: review+
Details | Diff | Splinter Review
3.18 KB, patch
khuey
: review+
Details | Diff | Splinter Review
10.46 KB, patch
khuey
: review+
Details | Diff | Splinter Review
1.08 KB, patch
khuey
: review+
Details | Diff | Splinter Review
1.45 KB, patch
khuey
: review+
Details | Diff | Splinter Review
2.34 KB, patch
khuey
: review+
Details | Diff | Splinter Review
8.07 KB, patch
khuey
: review+
Details | Diff | Splinter Review
No description provided.
Attachment #8371475 - Flags: review?(peterv)
Attachment #8371476 - Flags: review?(peterv)
Attachment #8371479 - Flags: review?(peterv)
Attachment #8371481 - Flags: review?(peterv)
Attachment #8371483 - Flags: review?(peterv)
Attachment #8371484 - Flags: review?(peterv)
Attachment #8371485 - Flags: review?(peterv)
Attachment #8371489 - Flags: review?(peterv)
Attachment #8371492 - Flags: review?(peterv)
Attachment #8371493 - Flags: review?(peterv)
Attachment #8391723 - Flags: review?(peterv)
Attachment #8391724 - Flags: review?(peterv)
Attachment #8391725 - Flags: review?(peterv)
Attachment #8391726 - Flags: review?(peterv)
Attachment #8391727 - Flags: review?(peterv)
Attachment #8391728 - Flags: review?(peterv)
Attachment #8371472 - Flags: review?(peterv) → review+
Attachment #8371475 - Flags: review?(peterv) → review+
Attachment #8371476 - Flags: review?(peterv) → review+
Attachment #8371478 - Flags: review?(peterv) → review+
Attachment #8371479 - Flags: review?(peterv) → review+
Attachment #8371481 - Flags: review?(peterv) → review+
Attachment #8371483 - Flags: review?(peterv) → review+
Keywords: leave-open
Comment on attachment 8371489 [details] [diff] [review]
Part k: GetScrollXY

Review of attachment 8371489 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/base/nsGlobalWindow.h
@@ +1195,5 @@
>  
>    // If aDoFlush is true, we'll flush our own layout; otherwise we'll try to
>    // just flush our parent and only flush ourselves if we think we need to.
> +  // Outer windows only.
> +  mozilla::CSSIntPoint GetScrollXY(bool aDoFlush);

I would say rename this to ScrollXY, but it seems odd to have a getter with a verb for a name :/
Attachment #8371489 - Flags: review?(peterv) → review+
Comment on attachment 8391721 [details] [diff] [review]
Part n: Split nsGlobalWindow::GetFullScreen into a forwarding and an assertion part

Review of attachment 8391721 [details] [diff] [review]:
-----------------------------------------------------------------

You ought to be able to assert that the XPCOM version of GetFullScreen is only ever called on an outer, no?
Attachment #8391721 - Flags: review?(peterv) → review+
(In reply to Kyle Huey [:khuey] (khuey@mozilla.com) from comment #25)
> Comment on attachment 8391721 [details] [diff] [review]
> Part n: Split nsGlobalWindow::GetFullScreen into a forwarding and an
> assertion part
> 
> Review of attachment 8391721 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> You ought to be able to assert that the XPCOM version of GetFullScreen is
> only ever called on an outer, no?

Maybe, but I'm not comfortable doing that.
Component: DOM → DOM: Core & HTML
You need to log in before you can comment on or make changes to this bug.