Closed
Bug 968814
Opened 11 years ago
Closed 11 years ago
Frames added in Toolbar have scrollbars if they have any content in them
Categories
(Add-on SDK Graveyard :: General, defect, P3)
Add-on SDK Graveyard
General
Tracking
(firefox29 fixed)
RESOLVED
FIXED
| Tracking | Status | |
|---|---|---|
| firefox29 | --- | fixed |
People
(Reporter: zer0, Unassigned)
References
Details
Attachments
(2 files)
|
46 bytes,
text/x-github-pull-request
|
zer0
:
review+
|
Details | Review |
|
2.42 KB,
patch
|
Sylvestre
:
approval-mozilla-aurora+
|
Details | Diff | Splinter Review |
From an add-on like this: https://gist.github.com/wbamberg/8725047
Updated•11 years ago
|
Priority: -- → P3
Comment 2•11 years ago
|
||
from bug 972935, it looks like this is a problem across platforms..
OS: Mac OS X → All
Hardware: x86 → All
Comment 3•11 years ago
|
||
Attachment #8378623 -
Flags: review?(zer0)
Comment 4•11 years ago
|
||
Commit pushed to master at https://github.com/mozilla/addon-sdk
https://github.com/mozilla/addon-sdk/commit/42aa9919e109921be63c311af4c0eef2f0b5562f
Merge pull request #1407 from Gozala/bug/toolbar-scroll
fix Bug 968814 - Fix undesired scrollbars in toolbars. r=@ZER0
Updated•11 years ago
|
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
| Reporter | ||
Updated•11 years ago
|
Attachment #8378623 -
Flags: review?(zer0) → review+
Comment 5•11 years ago
|
||
[Approval Request Comment]
Bug caused by (feature/regressing bug #): New SDK toolbars
User impact if declined: On some older OSX platforms the toolbar will show a small scrollbar
Testing completed (on m-c, etc.): On Nightly for over a week, little add-on code uses this though so probably little real-world testing.
Risk to taking this patch (and alternatives if risky): The change is just some styling corrections, very low risk.
String or IDL/UUID changes made by this patch: None
Attachment #8384939 -
Flags: approval-mozilla-aurora?
Updated•11 years ago
|
Attachment #8384939 -
Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Comment 6•11 years ago
|
||
status-firefox29:
--- → fixed
You need to log in
before you can comment on or make changes to this bug.
Description
•