Closed Bug 968830 Opened 11 years ago Closed 4 months ago

Query string parsing in netError.xhtml pages is fragile.

Categories

(Core :: DOM: Navigation, defect)

Product:
Core
Component:
DOM: Navigation
Type:
defect

Tracking

()

Status:
RESOLVED WORKSFORME

People

(Reporter: bobowen, Unassigned)

References

(Blocks 1 open bug)

Details

The query string parsing for parameters to the network error page relies on the order and existence of the various single letter parameters.

This makes the parsing very fragile.
Component: Networking → Document Navigation
Severity: minor → S4

We use URLSearchParams now so this isn't so fragile anymore. 🎉

https://searchfox.org/mozilla-central/rev/b1cffa04131a77e5e118d86d6366e0d660a3072b/toolkit/content/aboutNetError.mjs#81

(though why that doesn't just use new URL(...).searchParams, goodness knows)

Status: NEW → RESOLVED
Closed: 4 months ago
Resolution: --- → WORKSFORME
You need to log in before you can comment on or make changes to this bug.