Closed Bug 968852 Opened 7 years ago Closed 7 years ago

Alarm check sign overlays the notification

Categories

(Firefox OS Graveyard :: Gaia::Clock, defect)

ARM
Gonk (Firefox OS)
defect
Not set
normal

Tracking

(b2g-v1.3 affected)

VERIFIED FIXED
1.4 S1 (14feb)
Tracking Status
b2g-v1.3 --- affected

People

(Reporter: chiorean.ioana, Assigned: mcav)

Details

(Whiteboard: [p=1])

Attachments

(2 files)

Attached image alarmCheck.jpg
Device: Geon from Geeksphone
OS: Boot3Gecko 1.3.0.0-prerelease (02/06 )

Steps to reproduce:
1. Go to clock App - Alarms
2. Set multiple alarms
3. Put them on/off 

Actual Results:
- The notification with the time remaining till the alarm goes off is overlapped bu the round check of the alarm (empty circle for off, fill circle for on)

Expected Results:
- the notification should not be overlapped by other signs.

Note: 
- please see attached screenshots and video here: https://www.youtube.com/watch?v=6ESXT7_gQAQ
Assignee: nobody → m
Target Milestone: --- → 1.4 S1 (14feb)
Whiteboard: [p=1]
Comment on attachment 8371655 [details]
Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/16055/files

Hey Marcus,

One of the changes causes a couple failures on the UI tests. I've left a comment on the GitHub pull request with some ideas on how you can avoid that.
Attachment #8371655 - Flags: review?(mike)
Comment on attachment 8371655 [details]
Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/16055/files

Gotcha, fixed that and Travis passes now.
Attachment #8371655 - Flags: review?(mike)
Comment on attachment 8371655 [details]
Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/16055/files

Verified locally--nice work :)
Attachment #8371655 - Flags: review?(mike) → review+
Landed in master:

https://github.com/mozilla-b2g/gaia/commit/369d6998876b78305a727ecfc4c65ed23792cc10
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
[previous landing was not squashed, this is the correct landing:]

https://github.com/mozilla-b2g/gaia/commit/c118f97ea531a657dabf4f2dabfc4dd9bfc02d8d
[Verified info]
Gaia      6e71ab4da1b08586ea0c758edb7aa199ee34cd2f
Gecko     https://hg.mozilla.org/mozilla-central/rev/bb030d47c946
BuildID   20140219160202
Version   30.0a1

[Testing result]
PASS
Notification that has not overlapped on mutil alarm. The bug fixed so I mark it to "VERIFIED"
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.