968852 - Alarm check sign overlays the notification

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::Clock, defect)

Description

[Ioana Chiorean]

Attachment: alarmCheck.jpg

Device: Geon from Geeksphone
OS: Boot3Gecko 1.3.0.0-prerelease (02/06 )

Steps to reproduce:
1. Go to clock App - Alarms
2. Set multiple alarms
3. Put them on/off 

Actual Results:
- The notification with the time remaining till the alarm goes off is overlapped bu the round check of the alarm (empty circle for off, fill circle for on)

Expected Results:
- the notification should not be overlapped by other signs.

Note: 
- please see attached screenshots and video here: https://www.youtube.com/watch?v=6ESXT7_gQAQ

Comment 1

[Marcus Cavanaugh [:mcav]]

Attachment: Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/16055/files

Comment 2

[Mike Pennisi [:jugglinmike]]

Comment on attachment 8371655 [details]
Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/16055/files

Hey Marcus,

One of the changes causes a couple failures on the UI tests. I've left a comment on the GitHub pull request with some ideas on how you can avoid that.

Comment 3

[Marcus Cavanaugh [:mcav]]

Comment on attachment 8371655 [details]
Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/16055/files

Gotcha, fixed that and Travis passes now.

Comment 4

[Mike Pennisi [:jugglinmike]]

Comment on attachment 8371655 [details]
Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/16055/files

Verified locally--nice work :)

Comment 5

[Marcus Cavanaugh [:mcav]]

Landed in master:

https://github.com/mozilla-b2g/gaia/commit/369d6998876b78305a727ecfc4c65ed23792cc10

Comment 6

[Marcus Cavanaugh [:mcav]]

[previous landing was not squashed, this is the correct landing:]

https://github.com/mozilla-b2g/gaia/commit/c118f97ea531a657dabf4f2dabfc4dd9bfc02d8d

Comment 7

[Edward Chen[:edchen]]

[Verified info]
Gaia      6e71ab4da1b08586ea0c758edb7aa199ee34cd2f
Gecko     https://hg.mozilla.org/mozilla-central/rev/bb030d47c946
BuildID   20140219160202
Version   30.0a1

[Testing result]
PASS
Notification that has not overlapped on mutil alarm. The bug fixed so I mark it to "VERIFIED"