968878 - Misc tweaks in PanelGridView layout

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: Awesomescreen, defect)

Description

[Lucas Rocha (:lucasr)]

So that it looks great on multiple screen sizes.

Comment 1

[Lucas Rocha (:lucasr)]

Attachment: Misc tweaks in PanelGridView's layout (r=margaret)

Comment 2

[Lucas Rocha (:lucasr)]

Comment on attachment 8371577 [details] [diff] [review]
Misc tweaks in PanelGridView's layout (r=margaret)

I'll show ibarlow some screenshots to get his input.

Comment 3

[Lucas Rocha (:lucasr)]

Phone (portrait): https://www.dropbox.com/sc/hfq8pcs6exb76o1/Ra7IcEbmWu
Phone (landscape): https://www.dropbox.com/sc/cwoe75hmyjonoca/JN9bZ0EYUy
Small tablet (portrait): https://www.dropbox.com/sc/t32ijfe0ooq76ls/3uYSBNr86I
Small tablet (landscape): https://www.dropbox.com/sc/xe577m7vpsm0sxs/S1pYYOVj_q

Still need to get screenshots for large tablets.

Ian, does this look good for you?

Comment 4

[Ian Barlow (:ibarlow)]

Looks pretty awesome :)

Comment 5

[:Margaret Leibovic]

Comment on attachment 8371577 [details] [diff] [review]
Misc tweaks in PanelGridView's layout (r=margaret)

Review of attachment 8371577 [details] [diff] [review]:
-----------------------------------------------------------------

I'd like to understand how these values were chosen, but this seems like a fine change to land. Screenshots look nice :)

::: mobile/android/base/resources/values-large-v11/dimens.xml
@@ +8,5 @@
>      <dimen name="browser_toolbar_height">56dp</dimen>
>      <dimen name="browser_toolbar_button_padding">16dp</dimen>
>      <dimen name="menu_popup_arrow_margin">8dip</dimen>
>      <dimen name="tabs_counter_size">26sp</dimen>
> +    <dimen name="panel_grid_view_column_width">200dp</dimen>

And we're still happy with the xlarge value as 250dp?
http://mxr.mozilla.org/mozilla-central/source/mobile/android/base/resources/values-xlarge-v11/dimens.xml#15

Just trying to make sense of where all these values come from :)

Comment 6

[Lucas Rocha (:lucasr)]

(In reply to :Margaret Leibovic from comment #5)
> Comment on attachment 8371577 [details] [diff] [review]
> Misc tweaks in PanelGridView's layout (r=margaret)
> 
> Review of attachment 8371577 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> I'd like to understand how these values were chosen, but this seems like a
> fine change to land. Screenshots look nice :)
> 
> ::: mobile/android/base/resources/values-large-v11/dimens.xml
> @@ +8,5 @@
> >      <dimen name="browser_toolbar_height">56dp</dimen>
> >      <dimen name="browser_toolbar_button_padding">16dp</dimen>
> >      <dimen name="menu_popup_arrow_margin">8dip</dimen>
> >      <dimen name="tabs_counter_size">26sp</dimen>
> > +    <dimen name="panel_grid_view_column_width">200dp</dimen>
> 
> And we're still happy with the xlarge value as 250dp?
> http://mxr.mozilla.org/mozilla-central/source/mobile/android/base/resources/
> values-xlarge-v11/dimens.xml#15
> 
> Just trying to make sense of where all these values come from :)

Yep, 250dp for xlarge works just fine, no need to change it :-)

Comment 7

[Lucas Rocha (:lucasr)]

https://hg.mozilla.org/integration/fx-team/rev/b9bd994b2ef5

Comment 8

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/b9bd994b2ef5