968918 - [B2G][Everything.me][Smart Collections] Revert to Default Icon

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Everything.me, defect)

Description

[Brogan Zumwalt [Inactive]]

Attachment: Screenshot

Description:
If user downloads multiple games from the marketplace, the icons for these games appear inside the "Games" smart collection icon. If user deletes these games the "Games" smart collection icon appears blank until opened instead of auto-populating with webapp icons.

Repro Steps:
1) Updated Buri to BuildID: 20140206004002
2) Open Marketplace app
3) Download multiple game apps (e.g. "Cut the Rope", "Slice Fruits!", "Pasjans/Solitaire")
4) Return to homescreen
5) Open "Social" Smart collection
6) Return to homescreen
7) Press and hold icon for downloaded game for 3+ seconds
8) Delete the game apps downloaded from step 3

Actual:
Deleting downloaded game apps results in "Games" smart collection appearing empty.

Expected:
If no Smart collection related apps exist on homescreen, Smart collection icon is auto populated with related webapps.

Environmental Variables:
Device: Buri v1.3 Mozilla RIL
BuildID: 20140206004002
Gaia: 467ef8c9145d9a57d35b0619db541d23b522b958
Gecko: a1fa925c40c2
Version: 28.0
Firmware Version: V1.2-device.cfg

Notes:
Repro frequency: 3/3, 100%
See attached: screenshot
Workaround: Tap affected smart collection and return to homescreen

Comment 1

[Jason Smith [:jsmith]]

Minor bug overall.

Comment 2

[Amir Nissim (:amirn)]

Web app icons are updated only when the user opens a collection. 3 icons are saved in the collection's settings.
This is a UX decision that was voted against when we implemented this feature.

Since you never opened the Games collection, web app icons were never retrieved from the server.
(The initial Games icon is hard coded)

The only possible fix I can think of is fetching web icons when there are none (regardless of opening the collection), if UX votes for it.

Comment 3

[Amir Nissim (:amirn)]

(In reply to Amir Nissim (Everything.me) from comment #2)
> Web app icons are updated only when the user opens a collection. 3 icons are
> saved in the collection's settings.
> This is a UX decision that was voted against when we implemented this
> feature.
> 
> Since you never opened the Games collection, web app icons were never
> retrieved from the server.
> (The initial Games icon is hard coded)
> 
> The only possible fix I can think of is fetching web icons when there are
> none (regardless of opening the collection), if UX votes for it.

** Please ignore my previous comment **

Web app icons are updated only when the user opens a collection. 3 icons are saved in the collection's settings.
This is a UX decision that was made when we implemented this feature.

Since you never opened the Games collection, web app icons were never retrieved from the server.
(The initial Games icon is actually hard coded)

The only possible fix I can think of is fetching web icons when there are none - regardless of opening the collection. 
Please ignore my previous comment. The correct one is:

Web app icons are updated only when the user opens a collection. 3 icons are saved in the collection's settings.
This is a UX decision that was voted against when we implemented this feature.

Since you never opened the Games collection, web app icons were never retrieved from the server.
(The initial Games icon is hard coded)

The only possible fix I can think of is fetching web icons when there are none (regardless of opening the collection), if UX votes for it.

Comment 4

[Amir Nissim (:amirn)]

Not sure how to proceed with this.

Should we 'fix' this behavior and make an API request to get web apps icons when a collection is emptied?

Comment 5

[Ran Ben Aharon [:ranbena] EverythingMe]

I'll talk about it with UX on our next meeting

Comment 6

[Peter Dolanjski [:pdol]]

While this is somewhat a corner case, ending up with an empty icon makes the homescreen look broken.
If we can only solve the case where we end up with an empty circle, per discussion with Ran, it lowers the risk.  The idea would be that we revert to the default icon (generic version).

Comment 7

[Peter Dolanjski [:pdol]]

Triage noted that this is present in 1.3 as well, so if we're going to block, it would have to be 1.3, but we're really late for 1.3 changes.

Ran, can you update this bug when you figure out what would be involved to fix this?

Comment 8

[Gregor Wagner [:gwagner]]

Any updates here?

Comment 9

[Amir Nissim (:amirn)]

Here is a shorter STR:

0. reset phone and go offline
1. drag an app to the Games collection (notice the icon updates)
2. open the Games collection and remove the app added in step 1.
3. go back to homescreen and notice the Games collection has an empty icon

Comment 10

[Amir Nissim (:amirn)]

Attachment: Github Pull Request

Comment 11

[Amir Nissim (:amirn)]

Comment on attachment 8388172 [details]
Github Pull Request

https://github.com/mozilla-b2g/gaia/pull/17004

Comment 12

[Amir Nissim (:amirn)]

Attachment: Github Pull Request

A patch is ready:
https://github.com/mozilla-b2g/gaia/pull/17004

Cristian, a small question on Github:
https://github.com/EverythingMe/gaia/commit/3aa23d1a795f9f9c908b409748278ff8c8cb4e40#commitcomment-5611414

Thanks.

Comment 13

[Cristian Rodriguez (:crdlc)]

Comment on attachment 8388173 [details] [review]
Github Pull Request

LGTM. When will we have unit tests? AFAIK all patches should have unit tests to land on master right now according latest messages from sheriffs

Comment 14

[Gregor Wagner [:gwagner]]

You can land on master but we wouldn't hold the release for it.

Comment 15

[Amir Nissim (:amirn)]

Added test and landed in master: https://github.com/mozilla-b2g/gaia/commit/905c940