Closed Bug 968955 Opened 11 years ago Closed 10 years ago

Generate and save notification timestamp when building notification

Categories

(Firefox OS Graveyard :: General, defect)

Product:
Firefox OS Graveyard
Component:
General
Platform:
ARM
Gonk (Firefox OS)
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED DUPLICATE of bug 967475

People

(Reporter: gerard-majax, Assigned: gerard-majax)

References

Details

(Whiteboard: [systemsfe])

Attachments

(2 files, 15 obsolete files)

0002-Bug-968955-Register-and-send-back-timestamp-of-Notif.patch
4.42 KB, patch
Details | Diff | Splinter Review
0002-Bug-968955-Use-timestamp-retrieved-from-system-if-it.patch
962 bytes, patch
Details | Diff | Splinter Review 
The timestamp of notification displayed in the notification tray is generated when we trigger the addNotification() code path of the system app, at https://github.com/mozilla-b2g/gaia/blob/5b95998910062d5919baee98c1b1b9ae82477ba4/apps/system/js/notifications.js#L310

In bug 967475 we re-trigger old notifications on reboot, hence the timestamp displayed is not consistent with the real date at which the notification has been sent.
Gecko patch that registers a timestamp in the notification storage and fill it back when sending the notification system message.
Gaia patch that makes use of the timestamp if it is provided
Depends on: 967475
Whiteboard: [systemfe]
Whiteboard: [systemfe] → [systemsfe]
Make sure we correctly format the date displayed
Attachment #8372084 - Attachment is obsolete: true
No need to change NotificationOptions dictionnary and update UUID for nsINotificationStorageCallback
Attachment #8372085 - Attachment is obsolete: true
Limiting the scope of changes to what is only needed.
Attachment #8372173 - Attachment is obsolete: true
Making sure we use a correct date in all cases
Attachment #8372148 - Attachment is obsolete: true
Rebasing on top of new patch for bug 967475
Attachment #8372195 - Attachment is obsolete: true
Rebased
Attachment #8372199 - Attachment is obsolete: true
Rebased
Attachment #8372343 - Attachment is obsolete: true
Rebased.
Attachment #8377032 - Attachment is obsolete: true
Rebased.
Attachment #8377034 - Attachment is obsolete: true
Rebased.
Attachment #8377512 - Attachment is obsolete: true
Rebased.
Attachment #8379800 - Attachment is obsolete: true
Rebased.
Attachment #8380220 - Attachment is obsolete: true
Rebased.
Attachment #8380361 - Attachment is obsolete: true
Rebased.
Attachment #8386802 - Attachment is obsolete: true
Rebased.
Attachment #8377511 - Attachment is obsolete: true
This will be dealt with in bug 967475 directly.
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → DUPLICATE
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: