968963 - [E.me] Collection static apps names are not translated

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Everything.me, defect)

Description

[Ross Kuhlman ([e-mail])]

Attachment: PreinstalledAppsEnglish.png

When the user performs an E.Me search, any related apps that are already installed on the device will be suggested first. These autosuggested apps always display in english, even if they are properly translated on the home page. This includes pre-installed apps.

Repro Steps:
1) Updated Buri to BuildID: 20140203004001
2) Tap on 'Social' E.Me app.
3) Observe the suggested apps that are already installed.

Actual:
Preinstalled apps display in English.

Expected:
App titles display in the appropriate language if a translation is available.

Environmental Variables:
Device: Buri v1.3 Moz RIL
BuildID: 20140203004001
Gaia: f9a37c77efb4621a1f57e4695b497d18601fe134
Gecko: 3d9d920ca43b
Version: 28.0a2
Firmware Version: v1.2-device.cfg

Notes:

Repro frequency: 100%
See attached: screenshot

Comment 1

[Mahay Alam Khan]

We've translated FxOS v 1.3 strings through pootle at mozilla.locamotion.org; how I do this fix? I find these strings in pootle, and wait for someone to push form their to upstream?

or I translate them here in respective order?

Comment 2

[Jason Smith [:jsmith]]

I think the problem here is that strings used for the apps here are using the English name, not the localized name. Sounds like a bug in the e.me Gaia code.

Comment 3

[Preeti Raghunath(:Preeti)]

Ran,

Can you please check if this is an e.me issue? Or rule out if not?

Comment 4

[Ran Ben Aharon [:ranbena] EverythingMe]

Sounds like a definite bug. Assigning Amir.

Comment 5

[Amir Nissim (:amirn)]

Attachment: Redirect to PR

Comment 6

[Amir Nissim (:amirn)]

Updated the patch to also handle cases where a collection is open while the language changes by closing the collection.

This is the only low-risk solution possible.

Comment 7

[Amir Nissim (:amirn)]

landed: https://github.com/mozilla-b2g/gaia/commit/4606c99

Comment 8

[Jason Smith [:jsmith]]

https://github.com/mozilla-b2g/gaia/commit/4606c99d4a3f4b95f26e726b2efc5e57089147f3

Comment 9

[Amir Nissim (:amirn)]

uplifted to v1.3: https://github.com/mozilla-b2g/gaia/commit/f495f10df8c6f2c056d22d1878d46bccdae24835

Comment 10

[Jason Smith [:jsmith]]

(In reply to Amir Nissim (Everything.me) from comment #9)
> uplifted to v1.3:
> https://github.com/mozilla-b2g/gaia/commit/
> f495f10df8c6f2c056d22d1878d46bccdae24835

Please backout. You need to get approval for all gaia landings at this point of the release.

See https://wiki.mozilla.org/Release_Management/B2G_Landing#v1.3.0.

Comment 11

[Amir Nissim (:amirn)]

Sorry. I thought 1.3+ means ok to land :(

Backed out here: https://github.com/mozilla-b2g/gaia/commit/b4e20c3be2205350ed15b4fc40acaeb15b190e97

Thanks Jason.

Comment 12

[Amir Nissim (:amirn)]

Comment on attachment 8374759 [details] [review]
Redirect to PR

Requesting approval for v1.3

Bug caused by: Never implemented
User impact: App names inside collections are not translated to device language
Risk to taking this patch: Low
String changes made: get localized name when rendering static apps in a Collection. If a Collection is open while device language changes - force close it.

Comment 13

[Ryan VanderMeulen [:RyanVM]]

v1.3: df60e9b49207d64da5647ab15760c122adabfba4