Closed
Bug 969080
Opened 10 years ago
Closed 10 years ago
onCommandHandler is dead code after bug 948213
Categories
(Firefox :: Toolbars and Customization, defect)
Firefox
Toolbars and Customization
Tracking
()
RESOLVED
FIXED
Firefox 30
| Tracking | Status | |
|---|---|---|
| firefox29 | --- | fixed |
People
(Reporter: MattN, Assigned: MattN)
References
Details
(Whiteboard: [Australis:P5][qa-])
Attachments
(1 file)
|
1.41 KB,
patch
|
Unfocused
:
review+
Dolske
:
approval-mozilla-aurora+
|
Details | Diff | Splinter Review |
<Unfocused> MattN: i think it should have been removed in http://hg.mozilla.org/mozilla-central/rev/7ea80c5d5a1e I seems like the last reference was removed there but the function was left around.
Attachment #8371832 -
Flags: review?(bmcbride)
|
Assignee | |
Updated•10 years ago
|
Component: Bookmarks & History → Toolbars and Customization
|
||
Updated•10 years ago
|
Attachment #8371832 -
Flags: review?(bmcbride) → review+
|
|
Assignee | |
Comment 1•10 years ago
|
||
Comment on attachment 8371832 [details] [diff] [review] v.1 Remove onCommandHandler [Approval Request Comment] Bug caused by (feature/regressing bug #): bug 948213 User impact if declined: Extensions might rely on an unused function that will be removed in 30. Testing completed (on m-c, etc.): Local test run on targeted directories Risk to taking this patch (and alternatives if risky): Very low (should be dead code) String or IDL/UUID changes made by this patch: None
Attachment #8371832 -
Flags: approval-mozilla-aurora?
|
||
Updated•10 years ago
|
Attachment #8371832 -
Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
|
|
Assignee | |
Comment 2•10 years ago
|
||
https://hg.mozilla.org/integration/fx-team/rev/53d61053f474
Flags: in-testsuite-
Whiteboard: [Australis:P5] → [Australis:P5][fixed-in-fx-team]
|
|
Assignee | |
Comment 3•10 years ago
|
||
https://hg.mozilla.org/releases/mozilla-aurora/rev/bb4d39ca1e7b
status-firefox29:
--- → fixed
|
||
Comment 4•10 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/53d61053f474
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Whiteboard: [Australis:P5][fixed-in-fx-team] → [Australis:P5]
Target Milestone: --- → Firefox 30
|
||
Updated•10 years ago
|
Whiteboard: [Australis:P5] → [Australis:P5][qa-]
You need to log in
before you can comment on or make changes to this bug.
Description
•