Closed Bug 969147 Opened 8 years ago Closed 8 years ago

Compute flex line cross-sizes earlier on, so we can split paginated flex containers sooner

Categories

(Core :: Layout, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla30

People

(Reporter: dholbert, Assigned: dholbert)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

Filing this bug on a bit of flexbox-layout refactoring, to help with bug 939897.

Right now, we compute the cross-sizes of all the flex items (potentially reflowing every single one), and then we compute the sizes of their flex lines, and then we're in a position to be able to (eventually) see which flex lines fit & which flex lines don't.

Instead, we should compute the sizes of the flex lines as-we-go, so we can split sooner and avoid needless reflows of flex items that aren't going to fit anyway.
Attached patch fix v1Splinter Review
This does two things:
 (a) Computes the size of each flex line as early as possible (right after we finish sizing its flex items).

 (b) Sums the sizes of our flex lines more proactively. (so that in bug 939897, we can compare this running total against the available height or width, and trigger a break when it surpasses it)
Attachment #8371926 - Flags: review?(matspal)
Attachment #8371926 - Flags: review?(matspal) → review+
https://hg.mozilla.org/mozilla-central/rev/43437cbeca1a
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla30
You need to log in before you can comment on or make changes to this bug.