969193 - [B2G][l10n][Cost Control] The string "OK" is not translated when launching cost control with a locked SIM

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::Cost Control, defect)

Description

[KTucker [:KTucker][Inactive 3/4/2016]]

Attachment: 2014-02-06-17-18-35.png

Description:
The string "OK" is not translated when launching Cost Control with a locked SIM.

Repro Steps:
1)  Updated Buri to Build ID: 20140203181708
2)  Set the phone language to "Spanish".
3)  Tap on "Settings".
4)  Tap on "SIM security".
5)  Tap on the "SIM PIN" toggle to enable it.
6)  Create a "SIM PIN" and then restart the phone.
7)  Tap on "Skip" when prompted to enter a SIM PIN.
8)  Tap on "Usage" app.
9)  Tap on "Skip" when prompted to enter a SIM PIN.

Actual:
The string "OK" is not translated at the bottom of the "Unlock your SIM to enable Usage." message.

Expected:
The string is translated to "Aceptar".

Environmental Variables
Device: Buri v 1.3.0 Mozilla RIL
Build ID: 20140206004002
Gecko: https://hg.mozilla.org/releases/mozilla-b2g28_v1_3/rev/a1fa925c40c2
Gaia: 467ef8c9145d9a57d35b0619db541d23b522b958
Platform Version: 28.0
Firmware Version: v1.2-device.cfg

Notes:
Repro frequency: 100%
See attached: screenshot

Comment 1

[KTucker [:KTucker][Inactive 3/4/2016]]

This issue does not occur on the Buri v 1.2.0 Mozilla RIL

Environmental Variables
Device: Buri v 1.2.0 Mozilla RIL
Build ID: 20140203004002
Gecko: http://hg.mozilla.org/releases/mozilla-b2g26_v1_2/rev/9250d1b1cb6e
Gaia: 539a25e1887b902b8b25038c547048e691bd97f6
Platform Version: 26.0
Firmware Version: v1.2-device.cfg

The string "OK" is translated to "Aceptar" in Cost Control.

Comment 2

[Jason Smith [:jsmith]]

This isn't a localization bug. We've already got translations for a OK button.

Comment 3

[Francesco Lodolo [:flod]]

Then I suggest removing the locale name from the subject. If it affects Spanish, it affects also all other locales we ship (and I'm surprised I don't have a similar report for my own locale).

Comment 4

[Francesco Lodolo [:flod]]

https://github.com/mozilla-b2g/gaia/blob/master/apps/costcontrol/index.html#L127

I don't see any string with id "confirm" in the .properties file

There's an "OK" string, but it doesn't seem to be used
https://github.com/mozilla-b2g/gaia/blob/master/apps/costcontrol/locales/costcontrol.en-US.properties#L85

I think it's pretty safe to use this one, and we could port it to 1.3 without new strings (so no late-l10n).

Comment 5

[Jason Smith [:jsmith]]

Yup, agreed.

Comment 6

[Jason Smith [:jsmith]]

(In reply to Jason Smith [:jsmith] from comment #5)
> Yup, agreed.

Although I'd expect the OK button string to be part of the system app, not the cost control app. Prompts are part of the system app.

Comment 7

[Francesco Lodolo [:flod]]

Attachment: Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/16084

Button is currently using a non existent string ID "confirm" as data-l10n-id.

Existing string with id “ok” seems to be unused in other contexts, so it should be safe to use it here.

Tested locally on Keon and work as expected. 

Waiting for review and then asking 1.3?, since we fix the l10n problem without introducing new strings.

Comment 8

[Francesco Lodolo [:flod]]

(In reply to Jason Smith [:jsmith] from comment #6)
> Although I'd expect the OK button string to be part of the system app, not
> the cost control app. Prompts are part of the system app.

Is such a thing possible? Out of curiosity I checked and I count 28 "OK" in my locale, across all .properties files.

Comment 9

[Francesco Lodolo [:flod]]

Ouch, didn't realize this was in Gaia::System. I'm moving this to CostControl and ask a review there, since we're not touching system.

Comment 10

[Ryan VanderMeulen [:RyanVM]]

Master: f1aa7a363bc38040d0ad942e993d8641af8db752

Comment 11

[Francesco Lodolo [:flod]]

Verified flashing master on device (git commit 7ef49416).

Comment 12

[John Ford [:jhford] CET/CEST Berlin Time]

Uplifted f1aa7a363bc38040d0ad942e993d8641af8db752 to:
v1.3: 87a9913f2c197815d65faf88f4a1db7233ac668a