Closed Bug 969275 Opened 7 years ago Closed 7 years ago

COPY_SEQUENCE_FIELD macro in NetworkUtils.h has coding error

Categories

(Firefox OS Graveyard :: Wifi, defect)

ARM
Gonk (Firefox OS)
defect
Not set
normal

Tracking

(blocking-b2g:1.3T+, b2g-v1.3T fixed)

RESOLVED FIXED
1.4 S1 (14feb)
blocking-b2g 1.3T+
Tracking Status
b2g-v1.3T --- fixed

People

(Reporter: dimi, Assigned: dimi)

Details

Attachments

(2 files, 2 obsolete files)

There is an coding error in COPY_SEQUENCE_FIELD macro
Attached patch Bug 969275 fix (obsolete) — Splinter Review
Attachment #8372139 - Flags: review?(vchang)
Marking 1.3t+ since we took the worker rewrite on 1.3t.
blocking-b2g: --- → 1.3T+
Comment on attachment 8372139 [details] [diff] [review]
Bug 969275 fix

Review of attachment 8372139 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/system/gonk/NetworkUtils.cpp
@@ +231,5 @@
>    }
>  }
>  
> +static void split(char* str, const char* sep, nsTArray<nsString>& result)
> +{

It's redundant to have two similar functions doing almost the same thing. I really hope to see the follow-up bug to clean it. r=me for it really fixes the problem and is a 1.3T blocker.
Attachment #8372139 - Flags: review?(vchang) → review+
Assignee: nobody → dlee
Attached patch Bug 969275 fix v2 (obsolete) — Splinter Review
Attachment #8372139 - Attachment is obsolete: true
Attachment #8373924 - Attachment is obsolete: true
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/b0c83e05dfef
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → 1.4 S1 (14feb)
You need to log in before you can comment on or make changes to this bug.