Closed
Bug 969275
Opened 12 years ago
Closed 11 years ago
COPY_SEQUENCE_FIELD macro in NetworkUtils.h has coding error
Categories
(Firefox OS Graveyard :: Wifi, defect)
Tracking
(blocking-b2g:1.3T+, b2g-v1.3T fixed)
| Tracking | Status | |
|---|---|---|
| b2g-v1.3T | --- | fixed |
People
(Reporter: dimi, Assigned: dimi)
Details
Attachments
(2 files, 2 obsolete files)
|
4.93 KB,
patch
|
Details | Diff | Splinter Review | |
|
4.93 KB,
patch
|
Details | Diff | Splinter Review |
There is an coding error in COPY_SEQUENCE_FIELD macro
|
Assignee | |
Comment 1•12 years ago
|
||
Attachment #8372139 -
Flags: review?(vchang)
|
||
Comment 2•12 years ago
|
||
Marking 1.3t+ since we took the worker rewrite on 1.3t.
blocking-b2g: --- → 1.3T+
|
||
Comment 3•11 years ago
|
||
Comment on attachment 8372139 [details] [diff] [review]
Bug 969275 fix
Review of attachment 8372139 [details] [diff] [review]:
-----------------------------------------------------------------
::: dom/system/gonk/NetworkUtils.cpp
@@ +231,5 @@
> }
> }
>
> +static void split(char* str, const char* sep, nsTArray<nsString>& result)
> +{
It's redundant to have two similar functions doing almost the same thing. I really hope to see the follow-up bug to clean it. r=me for it really fixes the problem and is a 1.3T blocker.
Attachment #8372139 -
Flags: review?(vchang) → review+
|
|
||
Updated•11 years ago
|
Assignee: nobody → dlee
|
|
Assignee | |
Comment 4•11 years ago
|
||
Attachment #8372139 -
Attachment is obsolete: true
|
|
Assignee | |
Updated•11 years ago
|
Attachment #8373924 -
Attachment is obsolete: true
|
|
Assignee | |
Comment 5•11 years ago
|
||
|
|
Assignee | |
Comment 6•11 years ago
|
||
|
|
Assignee | |
Updated•11 years ago
|
Keywords: checkin-needed
|
||
Comment 7•11 years ago
|
||
Keywords: checkin-needed
|
|
||
Comment 8•11 years ago
|
||
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → 1.4 S1 (14feb)
|
|
||
Comment 9•11 years ago
|
||
status-b2g-v1.3T:
--- → fixed
You need to log in
before you can comment on or make changes to this bug.
Description
•