969335 - Defect - Deleting all the Top Sites leaves bottom bar unable to close

Status: RESOLVED INCOMPLETE

(Firefox for Metro Graveyard :: App Bar, defect)

Description

[Matthew Wilcoxson]

User Agent: Mozilla/5.0 (Windows NT 6.2; WOW64; rv:28.0) Gecko/20100101 Firefox/28.0 (Beta/Release)
Build ID: 20140203004003

Steps to reproduce:

1. Ater visiting several sites I went back to start page (with Top Sites on). 
2. Firefox had recorded my top sites but I didnt want them so I proceeded to delete them. I selecting them with the "pull down touch" and clicked the delete from the bottom bar.
3. Additional ones appeared to replace the ones I deleted (as is normal I think) but eventually I was left with none.



Actual results:

All sites were deleted but the bottom bar still remained with an "Undelete" button. I could not close the bar, even by clicking somewhere else on the page. All I could do was press undelete then reselect a site and then unselect it. The bar disappeared then but I was still left with sevwral sites.


Expected results:

The bar should close when the screen is tpuched outside of the bar - or there should be a close button.

Comment 1

[Sam Foster [:sfoster] (he/him)]

We should add a close button to the bar to allow the user to explicitly commit to the action and dismiss the bar

Comment 2

[Matt Brubeck (:mbrubeck)]

We'll need to add a close button here:
http://hg.mozilla.org/mozilla-central/file/d05c721ea1b0/browser/metro/base/content/browser.xul#l366

and some code to go with it, and decide under what conditions it should be shown.  We could show it only when showing the "restore" button, e.g.:
http://hg.mozilla.org/mozilla-central/file/d05c721ea1b0/browser/metro/base/content/startui/BookmarksView.js#l240

Comment 3

[Rodrigo Silveira [:rsilveira] [:rodms]]

related to bug 877875. There's some discussion there about tapping empty space to dismiss context bar too.

Comment 4

[Firefox Bug Husbandry Bot]

Mass close of bugs in obsolete product https://bugzilla.mozilla.org/show_bug.cgi?id=1350354