969346 - srcdoc iframe child of srcdoc iframe is not getting loaded

Status: RESOLVED FIXED

(Core :: Layout: Images, Video, and HTML Frames, defect)

Description

[Daniel DeLorme]

User Agent: Mozilla/5.0 (X11; Ubuntu; Linux x86_64; rv:26.0) Gecko/20100101 Firefox/26.0 (Beta/Release)
Build ID: 20131206152142

Steps to reproduce:

I generated some html programatically by converting nested iframes with src into nested iframes with srcdoc.

A simple ruby script to reproduce to bug:
require "cgi"
for i in 1..10
  html = "#{i} #{html}"
  html = "<iframe srcdoc='#{CGI.escapeHTML(html)}'></iframe>"
end
puts html


Actual results:

The toplevel iframe has content, but any embedded iframe (with srcdoc) is empty.


Expected results:

All iframes should have content, no matter how deep they are nested.

Comment 1

[Boris Zbarsky [:bzbarsky]]

Presumably we should skip the URI recursion checks when the iframe is loading a srcdoc.

James, do you have time to take a look?

Comment 2

[James Kitchener (:jkitch)]

Attachment: Allow nesting

This skips the recursion check for about:srcdoc URIs.  Their need to be specified inline makes loops impossible without the aid of a src URI, which the code will still block.

Note that the maximum nested depth limit of about 10 is still enforced.

Comment 3

[James Kitchener (:jkitch)]

Attachment: Allow nesting

comment typo

Comment 4

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 8372749 [details] [diff] [review]
Allow nesting

Could we check the scheme for "about" before doing the GetSpec?  Otherwise for data: URIs we'll end up copying a huge string for no particularly good reason...

>+    pframe.contentWindow.addEventListener("load", function () {

Just use addLoadEvent(); if the toplevel onload is firing the frames will be ready too.

r=me with those changes

Comment 5

[James Kitchener (:jkitch)]

Attachment: Allow nesting

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/2d59b02718f7

Comment 7

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

https://hg.mozilla.org/mozilla-central/rev/2d59b02718f7