969445 - Don't show progress bar in about:privatebrowsing

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Lucas Rocha (:lucasr)]

Just like we don't do so in about:home and about:reader.

Comment 1

[Lucas Rocha (:lucasr)]

Attachment: Don't show progress bar in about:privatebrowsing (r=mfinkle)

Comment 2

[Lucas Rocha (:lucasr)]

https://hg.mozilla.org/integration/fx-team/rev/671661f4bd5b

Comment 3

[Aaron Train [:aaronmt]]

Context? This is on new private tab right?

Comment 4

[Mark Finkle (:mfinkle) (use needinfo?)]

(In reply to Aaron Train [:aaronmt] from comment #3)
> Context? This is on new private tab right?

Yes, about:privatebrowsing

Comment 5

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/671661f4bd5b

Comment 6

[Ioana Chiorean]

Build Nightly 30.0a1 02/10 
Galaxy Nexus 4.3 and Motorola RAZR 4.0.4

The progress bar was excluded. Opening about:privatebrowsing will not display the progress. 

As I think it won't affect this I am wondering if it will be pushed to Aurora too?

Comment 7

[Lucas Rocha (:lucasr)]

(In reply to Ioana Chiorean from comment #6)
> Build Nightly 30.0a1 02/10 
> Galaxy Nexus 4.3 and Motorola RAZR 4.0.4
> 
> The progress bar was excluded. Opening about:privatebrowsing will not
> display the progress. 
> 
> As I think it won't affect this I am wondering if it will be pushed to
> Aurora too?

I'm planning to uplift this to Aurora as it's just a minor UX improvement.

Comment 8

[Brian Nicholson (:bnicholson)]

Could we just change the filter to exclude all pages starting with about:? When do we ever want to show progress for an about: page?

Comment 9

[Lucas Rocha (:lucasr)]

(In reply to Brian Nicholson (:bnicholson) from comment #8)
> Could we just change the filter to exclude all pages starting with about:?
> When do we ever want to show progress for an about: page?

Good point, file a follow-up?(In reply to Lucas Rocha (:lucasr) from comment #7)

> (In reply to Ioana Chiorean from comment #6)
> I'm planning to uplift this to Aurora as it's just a minor UX improvement.

Err, I actually meant that I'm *not* planning to uplift.