Closed Bug 969474 Opened 6 years ago Closed 4 years ago

Odd back button behavior for Welcome to Sync

Categories

(Firefox :: Sync, defect)

defect
Not set

Tracking

()

VERIFIED FIXED
Firefox 43
Iteration:
43.3 - Sep 21
Tracking Status
firefox43 --- verified

People

(Reporter: rfeeley, Assigned: markh)

References

Details

Attachments

(2 files, 1 obsolete file)

Attached image back-button.png
When the user enters sync through several of the entry points, the back button on the Welcome to Sync screen becomes enabled, but does nothing.
Back button leads to bad behavior - can we disable it for about:accounts? 

https://github.com/mozilla/fxa-content-server/issues/661
Blocks: 969593
Back button has to work, y'all. It's a fundamental behavior of the web.
The bug is also reproducible on Windows 7 x64 using following builds:
- 33.0a1 (2014-07-10);
- 32.0a2 (2014-07-10);
- 31 beta 9;
- 30.0 release.
OS: Mac OS X → All
Hardware: x86 → All
Version: unspecified → Trunk
Blocks: 1199303
Hi Drew,
  Without this patch, loading about:accounts in a new tab enables the back-button, but pressing back does nothing. With this patch it works as expected (ie, the button remains disabled)
Assignee: nobody → markh
Status: NEW → ASSIGNED
Attachment #8659086 - Flags: review?(adw)
I assumed that simple change wouldn't break the tests, but you'd think I'd know by now that that assumption is almost always wrong :/
Attachment #8659086 - Attachment is obsolete: true
Attachment #8659086 - Flags: review?(adw)
Attachment #8659094 - Flags: review?(adw)
Comment on attachment 8659094 [details] [diff] [review]
0001-Bug-969474-fix-behaviour-of-back-button-on-about-acc.patch

Review of attachment 8659094 [details] [diff] [review]:
-----------------------------------------------------------------

(In reply to Mark Hammond [:markh] from comment #5)
> I assumed that simple change wouldn't break the tests, but you'd think I'd
> know by now that that assumption is almost always wrong :/

You're an optimist! :-) (Me too.)
Attachment #8659094 - Flags: review?(adw) → review+
https://hg.mozilla.org/mozilla-central/rev/f064857f340e
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 43
Iteration: --- → 43.3 - Sep 21
Flags: firefox-backlog+
 I have reproduced this bug on Firefox nightly Version 30.0a1

It's fixed and verified on Latest Developer Edition
Build ID 	20151017004025
User Agent 	Mozilla/5.0 (Windows NT 6.3; rv:43.0) Gecko/20100101 Firefox/43.0

Tested OS- Windows8.1 32bit
QA Whiteboard: [testday-20151016]
Thanks, :Antora!
Marking as verified.
Status: RESOLVED → VERIFIED
Opened https://bugzilla.mozilla.org/show_bug.cgi?id=1233668 - the patch for this bug does not add the first FxA page to history and causes a problem in Firefox Accounts - window.history.back() cannot be used to go back to the initial page!
You need to log in before you can comment on or make changes to this bug.