969474 - Odd back button behavior for Welcome to Sync

Status: VERIFIED FIXED

(Firefox :: Sync, defect)

Description

[Ryan Feeley [:rfeeley]]

Attachment: back-button.png

When the user enters sync through several of the entry points, the back button on the Welcome to Sync screen becomes enabled, but does nothing.

Comment 1

[Edwin Wong [:edwong]]

Back button leads to bad behavior - can we disable it for about:accounts? 

https://github.com/mozilla/fxa-content-server/issues/661

Comment 2

[Crystal Beasley [:skinny, :crystal]]

Back button has to work, y'all. It's a fundamental behavior of the web.

Comment 3

[Flaviu Cos]

The bug is also reproducible on Windows 7 x64 using following builds:
- 33.0a1 (2014-07-10);
- 32.0a2 (2014-07-10);
- 31 beta 9;
- 30.0 release.

Comment 4

[Mark Hammond [:markh] [:mhammond]]

Attachment: 0001-Bug-969474-fix-behaviour-of-back-button-on-about-acc.patch

Hi Drew,
  Without this patch, loading about:accounts in a new tab enables the back-button, but pressing back does nothing. With this patch it works as expected (ie, the button remains disabled)

Comment 5

[Mark Hammond [:markh] [:mhammond]]

Attachment: 0001-Bug-969474-fix-behaviour-of-back-button-on-about-acc.patch

I assumed that simple change wouldn't break the tests, but you'd think I'd know by now that that assumption is almost always wrong :/

Comment 6

[Drew Willcoxon :adw]

Comment on attachment 8659094 [details] [diff] [review]
0001-Bug-969474-fix-behaviour-of-back-button-on-about-acc.patch

Review of attachment 8659094 [details] [diff] [review]:
-----------------------------------------------------------------

(In reply to Mark Hammond [:markh] from comment #5)
> I assumed that simple change wouldn't break the tests, but you'd think I'd
> know by now that that assumption is almost always wrong :/

You're an optimist! :-) (Me too.)

Comment 7

[Pulsebot]

https://hg.mozilla.org/integration/fx-team/rev/f064857f340e

Comment 8

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/f064857f340e

Comment 9

[Saheda Reza [:Antora]]

 I have reproduced this bug on Firefox nightly Version 30.0a1

It's fixed and verified on Latest Developer Edition
Build ID 	20151017004025
User Agent 	Mozilla/5.0 (Windows NT 6.3; rv:43.0) Gecko/20100101 Firefox/43.0

Tested OS- Windows8.1 32bit

Comment 10

[Petruta Horea [:phorea], Desktop Test Engineering (back on Sep 5th)]

Thanks, :Antora!
Marking as verified.

Comment 11

[Shane Tomlinson [:stomlinson]]

Opened https://bugzilla.mozilla.org/show_bug.cgi?id=1233668 - the patch for this bug does not add the first FxA page to history and causes a problem in Firefox Accounts - window.history.back() cannot be used to go back to the initial page!