Closed
Bug 969561
Opened 11 years ago
Closed 11 years ago
Remove binaries from git (apk factory) and add build step to deploy
Categories
(Marketplace Graveyard :: Integration, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: kumar, Unassigned)
Details
Some binaries were committed here: https://github.com/mozilla/apk-factory-service/tree/878d5e90dc935d04df125d3bd6c65c74e0e064bb/node_modules/toobusy/build
We need to remove them from git and add `npm rebuild` to the deploy step. Maybe ops would prefer to use rpms or something but you get the idea.
|
Reporter | |
Comment 1•11 years ago
|
||
Does the apk-factory deploy script run `npm rebuild` now?
Flags: needinfo?(jthomas)
|
|
Reporter | |
Comment 2•11 years ago
|
||
or include RPMs of toobusy?
|
|
Reporter | |
Comment 3•11 years ago
|
||
btw, we removed the binaries from git: https://github.com/mozilla/apk-factory-service/commit/323378d30bfd081a98a4e8c5ea9476b45492dcee
|
||
Comment 4•11 years ago
|
||
(In reply to Kumar McMillan [:kumar] (needinfo for quickness) from comment #1)
> Does the apk-factory deploy script run `npm rebuild` now?
Yes https://github.com/mozilla/apk-factory-service/blob/master/build#L26
Flags: needinfo?(jthomas)
|
|
Reporter | |
Comment 5•11 years ago
|
||
Thanks Jason. This should all be working now.
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•