Closed Bug 969564 Opened 6 years ago Closed 6 years ago
Update Checker optional
46 bytes, text/x-github-pull-request
|Details | Review|
Setting up the FakeUpdateChecker is causing problems on the Tarako. Since there's not much engineering support in figuring out why this is, I'd like to make this step optional, but enabled by default, so we can skip it when running b2gperf.
Comment on attachment 8372509 [details] [review] Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/16094 I really hate adding new command lines switches, they are like a bad disease and it makes it harder to teach, use and document the code. You set a bad precedent to use one to band-aid something that doesn't work rather than fix the atom in the first place. I'd much rather see the atom fixed properly, to detect whether it can run or not and skip and also to output to the logs when it was not run.
Attachment #8372509 - Flags: review?(zcampbell) → review-
Fair point, I'll do that.
Assignee: nobody → mar.castelluccio
(In reply to Ryan VanderMeulen [:RyanVM UTC-5] from comment #4) > https://hg.mozilla.org/integration/mozilla-inbound/rev/00d49079bcbc This was from bug 969654, sorry for the spam.
It appears this is no longer necessary; the b2gperf jobs are running against Tarako devices, so I'm going to punt on this.
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → WONTFIX
You need to log in before you can comment on or make changes to this bug.